CloudTrail Improvements to avoid prowler alerts #342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Point to managedkube fork cloudtrail s3 bucket
kubernetes-ops/terraform-modules/aws/cloudposse/aws-cloudtrail-cloudwatch-alarms/main.tf
Lines 4 to 15 in bdd3682
kubernetes-ops/terraform-modules/aws/cloudposse/aws-cloudtrail-cloudwatch-alarms/main.tf
Line 12 in a6c0f77
s3_object_ownership
helps us to avoid the deprecated use of acl and use bucket policies, this solves the prowler alert:[extra7172] Check if S3 buckets have ACLs enabled | us-west-2: Bucket x2-ops-cloudtrail-cloudwatch-alarms has bucket ACLs disabled!
Increase retention to 365 days in order to this alerts.:
us-west-2: x2-ops-cloudtrail-cloudwatch-alarms Log Group does not have 365 days retention period!
.kubernetes-ops/terraform-modules/aws/cloudposse/aws-cloudtrail-cloudwatch-alarms/main.tf
Line 20 in a6c0f77
they have given us a good follow up and are about to integrate the pr.
New inputs vars to make secure s3 bucket
kubernetes-ops/terraform-modules/aws/cloudposse/aws-cloudtrail-cloudwatch-alarms/variables.tf
Lines 30 to 72 in a6c0f77