Add P08 Read Only support. #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antuspcm
approved these changes
Apr 23, 2023
There was a problem hiding this comment.
Ive got a better fix for the p04 and p08 sum confusion so we can check them in logical order (the P04 needs to check two additional bytes for FF FF), and a fix for the broken block sum on P08. So lets merge this to get through the back log of work, then revisit those things. We also need to remove or change the P04 development warning, and/or add one for P08.
|
Yup, I had one all ready, just couldn't create the PR, it would of caused a conflict situation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.