Use kagglesdk as a package. #825
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we'll only have to update it in one place. During testing, I was able to verify it was installing and using the pip package. However, I couldn't test end-to-end because the OAuth changes were getting in the way. I'll follow up to get those resolved next week. http://b/356194863
jplotts
commented
Jul 11, 2025
| @@ -2,3 +2,4 @@ certifi >= 14.05.14 | |||
| six >= 1.10 | |||
| python_dateutil >= 2.5.3 | |||
| urllib3 >= 1.15.1 | |||
| kagglesdk | |||
There was a problem hiding this comment.
Steve - do you know whether requirements.in and requirements.txt are still required? During local testing, it worked fine with just the pyproject.toml changes. Can we remove these files?
There was a problem hiding this comment.
I think they are needed during distribution, which runs in cloudbuild. Could be wrong ...
stevemessick
approved these changes
Jul 11, 2025
|
Files of those names are referenced in `tools/releases/Dockerfile` but I
think it's using the files in that dir, not the top-level ones.
…On Fri, Jul 11, 2025 at 1:13 PM Jim Plotts ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In requirements.in
<#825 (comment)>:
> @@ -2,3 +2,4 @@ certifi >= 14.05.14
six >= 1.10
python_dateutil >= 2.5.3
urllib3 >= 1.15.1
+kagglesdk
Steve - do you know whether requirements.in and requirements.txt are
still required? During local testing, it worked fine with just the
pyproject.toml changes. Can we remove these files?
—
Reply to this email directly, view it on GitHub
<#825 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACA7VDLG44GZLNMRLK6JOK33IALFNAVCNFSM6AAAAACBKV2HQWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMJRHA2DMMJRGM>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we'll only have to update it in one place.
During testing, I was able to verify it was installing and using the pip package. However, I couldn't test end-to-end because the OAuth changes were getting in the way. I'll follow up to get those resolved next week.
http://b/356194863