Skip to content

Fix a type error in Kaggle notebook auto-auth flow #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

erdalsivri
Copy link
Contributor

_get_access_token_from_file returns a tuple but the caller assumes it is a string, which fails later when it tries to use the token.

_get_access_token_from_file returns a tuple but the caller assumes it is
a string, which fails later when it tries to use the token.
@erdalsivri erdalsivri requested a review from jplotts July 11, 2025 20:36
Copy link
Contributor

@jplotts jplotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, isn't this generated by kapigen?

The reason I'm asking is because I have PR #825 to delete this file and use the one in the kagglesdk repo. I'm happy to approve this, but it's going to get lost when I merge. If you just make the change in kapigen instead, I can make sure it's picked up with the next kagglesdk release. Wdyt?

@erdalsivri
Copy link
Contributor Author

Sorry, isn't this generated by kapigen?

The reason I'm asking is because I have PR #825 to delete this file and use the one in the kagglesdk repo. I'm happy to approve this, but it's going to get lost when I merge. If you just make the change in kapigen instead, I can make sure it's picked up with the next kagglesdk release. Wdyt?

Good point! I keep forgetting that. Prepared another PR

@erdalsivri erdalsivri closed this Jul 11, 2025
@erdalsivri erdalsivri deleted the fix-kaggle-kernel-auth branch July 11, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants