Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring mcerd module #87

Merged
merged 4 commits into from
Oct 13, 2020
Merged

Refactoring mcerd module #87

merged 4 commits into from
Oct 13, 2020

Commits on Oct 11, 2020

  1. MCERD.run method split into smaller functions 

    - Initial refactoring of mcerd module before attempting fix #84
- Removed name mangling (#72) (may still need to rethink which
  attributes should be public and which should be private)
- Moved MCERD.stop_process method to subprocess_utils, split the
  parameters given to TASKKILL (#19) and used subprocess.run instead of
  subprocess.call
- Added a FIXME for a rare bug caused by delete_unneeded_files method
    @jussiks
    jussiks committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    71ed68d View commit details
    Browse the repository at this point in the history

  2. Fixed expected return codes on Unix

    @jussiks
    jussiks committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    e5d5ace View commit details
    Browse the repository at this point in the history

  3. Minor test tweaks 

    - Cast the return value of Popen.poll to int when checking that it
  is a non-zero integer.
- Assertions made after exiting the Popen context manager in case the
  test expects a finished process.
    @jussiks
    jussiks committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    8b14c34 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'mcerd_refactor' of https://github.com/JYU-IBA/potku int… 

    …o mcerd_refactor

Someone has once managed to cause a merge conflict by forgetting to
pull changes they themselves made on another system...
    @jussiks
    jussiks committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    965a6ba View commit details
    Browse the repository at this point in the history