Refactoring mcerd module #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Initial refactoring of mcerd module before attempting fix #84 - Removed name mangling (#72) (may still need to rethink which attributes should be public and which should be private) - Moved MCERD.stop_process method to subprocess_utils, split the parameters given to TASKKILL (#19) and used subprocess.run instead of subprocess.call - Added a FIXME for a rare bug caused by delete_unneeded_files method
- Cast the return value of Popen.poll to int when checking that it is a non-zero integer. - Assertions made after exiting the Popen context manager in case the test expects a finished process.
…o mcerd_refactor Someone has once managed to cause a merge conflict by forgetting to pull changes they themselves made on another system...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little bit of refactoring to make the module easier to test before actually doing anything about #84.