WatchFaceAnalog: Use status icons class #1963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't change any functionality, it just reuses the existing StatusIcon class rather than duplicate its code in the Analog face. |
|
Build size and comparison to main:
|
Instead of recreating the status icons for BLE and battery, we can reuse the StatusIcon class to automatically display them.
vkareh
force-pushed
the
face-analog-statusicons
branch
from
4cda48c to
1868c88
Compare
|
This has been discussed before, but I'm willing to discuss it further: #1336. |
|
@FintasticMan ah, I see the point. I wasn't aware of that discussion, but it makes sense with regards to the display overlap. It feels like a useful widget, the status icons, but it's being used only in a single context, which is unfortunate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of recreating the status icons for BLE and battery, we can reuse the StatusIcon class to automatically display them.