Rationalise use of status in faces. #1975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use StatusIcons in WatchFaceAnalog. Remove unused code relating to explicit status icons.
|
Build checks have not completed. Possible reasons for this are:
|
|
Okay - I will review those threads. I discovered the issue because the analogue face behaves different to other faces / apps which gives an inconsistent UI. Hopefully I will find some info in one of those threads that provides a roadmap for resolving this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds StatusIcons to WatchFaceAnalog. This rationalises the use of StatusIcons that was previously used on many screens but not the analogue watchface. The core advantage is that we have common code that reduces undesirable or unexpected behaviour, e.g. changes to StatusIcons would not be evident in the analouge watch face.