Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds page indicator to music app #1875

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adds page indicator to music app #1875

wants to merge 2 commits into from
+20 −4

Conversation

SteveAmor
Copy link
Contributor

Fixes #1391

@github-actions
Copy link

github-actions bot commented Oct 4, 2023 •
edited
Loading

Build size and comparison to main:

Section Size Difference
text 374672B 64B
data 948B 0B
bss 63504B 0B

@SteveAmor
Copy link
Contributor Author

InfiniSim_2023-10-04_202308

@minacode
Copy link
Contributor

minacode commented Oct 4, 2023

I imagine it could look a little better with a little margin around the buttons. What do you think?

@SteveAmor
Copy link
Contributor Author

The page indicator is 2px wide.
However, if I move the buttons 3px, it conveniently has a 3px space between the play/pause button too, making it nice and symmetrical.
What do people think?

InfiniSim_2023-10-05_080028

For comparison, here are the buttons moved 2px

2px

@minacode
Copy link
Contributor

minacode commented Oct 5, 2023

I like the first image where the bar is not touching the button.

@SteveAmor
Copy link
Contributor Author

PR updated to move the buttons 3px.

@SteveAmor
Copy link
Contributor Author

I experimented with hiding or deleting the page indicator object when you switch pages. According to the simulator, hiding the object used more lvgl memory than deleting and creating. So I went with deleting. I guess it used more memory as you actually had more objects at any one time, with one of them hidden.

@LinuxinaBit LinuxinaBit mentioned this pull request Nov 9, 2023
Closed
@SteveAmor SteveAmor changed the title Adds scroll bar to music app Adds page indicator to music app Dec 1, 2024
@mark9064 mark9064 added this to the 1.16.0 milestone Dec 2, 2024
@mark9064 mark9064 added the enhancement Enhancement to an existing app/feature label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Enhancement to an existing app/feature
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

Add Scroll Bar to the Music App
3 participants
@SteveAmor @minacode @mark9064