Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music app redesign #1901

Closed
wants to merge 8 commits into from
Closed

Music app redesign #1901

wants to merge 8 commits into from

Conversation

coffandro
Copy link

I found the stock music app unsatisfactory so therefor I decided to redesign it, on my watch I've found it to be more stable than stock and it's easier to see what buttons do and such
image

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed

@LinuxinaBit
Copy link

This is great, it improves accessibility of the volume icons and is a better overall solution than #1875 .
It does have some minor issues (the title might need a better way to fit on screen) but I think those can be fixed.
I hope this gets merged :)

@coffandro
Copy link
Author

Thank you, I 100% agree, also wanted to somehow make the title more or less fill the entire empty space but couldn't find a way to do it in LGVL

@FintasticMan FintasticMan added the UI/UX User interface/User experience label Nov 16, 2023
@coffandro
Copy link
Author

Newest version provides a better layout for the song name though it does have a tendency to overflow slightly which I'm working on

@JustScott
Copy link
Contributor

JustScott commented Jan 9, 2024

Loving this design! I noticed that swiping up and down increases and decreases the volume, removing the ability to swipe down to exit the app. I'm not sure if this was intentional or a bug, but assuming it was intentional, I think the Infinitime developers prefer apps to not take over the swipe to exit ability (I think I saw someone say that in a PR, I may also be wrong). Anyways... I'll still be using it, thank you for the work you did on this!

@JustScott
Copy link
Contributor

@coffandro I noticed you changed the notification label color in this pull request, as that's unrelated to the music app it should probably be removed.

@coffandro
Copy link
Author

That is true, updating it in a day or so for 1.14 and ill remove it and recheck everything then

@coffandro
Copy link
Author

Loving this design! I noticed that swiping up and down increases and decreases the volume, removing the ability to swipe down to exit the app. I'm not sure if this was intentional or a bug, but assuming it was intentional, I think the Infinitime developers prefer apps to not take over the swipe to exit ability (I think I saw someone say that in a PR, I may also be wrong). Anyways... I'll still be using it, thank you for the work you did on this!

Pretty sure the stock music app already lock up/down, i have just adapted it for my own use case, and the one i see as more practical, where the music app "takes over" control until you press the button, can remove this if a maintainer wants me to tho

@JustScott
Copy link
Contributor

That is true, updating it in a day or so for 1.14 and ill remove it and recheck everything then

I just adapted it to 1.14 so i could merge it into my fork, you can use it if you'd like! https://github.com/JustScott/InfiniTime/tree/change_music_app_design

@coffandro coffandro closed this by deleting the head repository Jul 22, 2024
@coffandro
Copy link
Author

Remaking the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX User interface/User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants