Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify test converter add gromacs test #671

Open
wants to merge 3 commits into
base: protos
Choose a base branch
from

Conversation

oerc0122
Copy link
Collaborator

Description of work

  • Refactor test_converter to reduce code duplication through pytest.mark.parametrize.
  • Replace os.path with pathlib.Path
  • Add gromacs-nvt test
    Instead implementing _converter_test to handle standard format testing.

Fixes
N/A

To test
Tests should pass.

@oerc0122 oerc0122 added styling Any issue related to styling CI/CD Something concerning the CI/CD pipeline labels Feb 14, 2025
@oerc0122 oerc0122 self-assigned this Feb 14, 2025
@oerc0122 oerc0122 changed the title Simplify test converter Simplify test converter add gromacs test Feb 14, 2025
@MBartkowiakSTFC
Copy link
Collaborator

One big advantage of the new version is that it is much shorter, and this for me counts already as 'easier to read'.

Would you like to replace the occurrences of the word typ with something clearer to a reader who expects it to be written in English?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Something concerning the CI/CD pipeline styling Any issue related to styling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants