Skip to content

Remove all references to Six #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2024
Merged

Remove all references to Six #393

merged 1 commit into from
May 22, 2024

Conversation

LowriJenkins
Copy link
Contributor

Description of work

Remove all references to Six

To test

Ticket

Acceptance criteria

  • Git grep finds no import six.
  • Tests still pass.

Code Review

  • Is the code of an acceptable quality?
  • Has the author taken into account the multi-threaded nature of the code?
  • Have the changes been recorded appropriately in a PR for release notes?
  • Has the manual system tests spreadsheet been updated?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed.

Final steps

  • Reviewer has updated the submodule in the main EPICS repo? See Reviewing work for the subModules of EPICS in the Git workflow page for details.
  • Reviewer has merged the associated PR for the release notes

@LowriJenkins LowriJenkins linked an issue May 17, 2024 that may be closed by this pull request
Remove six usage ISISComputingGroup/IBEX#8297
Closed
2 tasks
@LowriJenkins LowriJenkins mentioned this pull request May 17, 2024
Closed
2 tasks
@LowriJenkins LowriJenkins removed a link to an issue May 17, 2024
Remove six usage ISISComputingGroup/IBEX#8297
Closed
2 tasks
@Chsudeepta Chsudeepta merged commit f018604 into master May 22, 2024
1 check failed
@Chsudeepta
Copy link
Contributor

Checked the occurrences of six and ran the tests to check anything is failing. Found OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chsudeepta Chsudeepta Chsudeepta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LowriJenkins @Chsudeepta