Skip to content

Remove six usage #8297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
rerpha opened this issue Apr 15, 2024 · 2 comments
Closed
2 tasks done

Remove six usage #8297

rerpha opened this issue Apr 15, 2024 · 2 comments
Assignees
@LowriJenkins
Labels
0 Friday no_release_notes Tickets that do not need release notes, use sparingly!
Milestone
SPRINT_2024_05_23

Comments

@rerpha
Copy link
Contributor

rerpha commented Apr 15, 2024 •
edited by Chsudeepta
Loading

we are no longer using python 2.7 and something tells me we won't be going back.

we should remove six from our code!

acceptance criteria

  • any uses of six are removed from our codebase
  • six is removed from requirements.txt
@rerpha rerpha added the Friday label Apr 15, 2024
@LowriJenkins LowriJenkins self-assigned this May 17, 2024
@LowriJenkins LowriJenkins mentioned this issue May 17, 2024
Merged
9 tasks
@LowriJenkins LowriJenkins linked a pull request May 17, 2024 that will close this issue
Remove all references to Six ISISComputingGroup/EPICS-inst_servers#393
Merged
9 tasks
@LowriJenkins LowriJenkins mentioned this issue May 17, 2024
Merged
2 tasks
@LowriJenkins LowriJenkins linked a pull request May 17, 2024 that will close this issue
Remove use of six ISISComputingGroup/EPICS-refl#57
Merged
2 tasks
This was referenced May 17, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
@LowriJenkins
Copy link
Contributor

LowriJenkins commented May 17, 2024 •
edited
Loading

Relies on genie-python for requirements so should be reviewed and merged before genie python:

Genie Python

Has its own requirement file that contains six, doesn't need to be reviewed and merged before genie-python (could leave these to a later time):

This was linked to pull requests May 17, 2024
Remove usage of six ISISComputingGroup/EPICS-DeviceEmulator#176
Merged
Remove usage of six ISISComputingGroup/EPICS-IOC_Test_Framework#629
Merged
Remove usage of six ISISComputingGroup/ibex_gui#1705
Merged
Remove references to six ISISComputingGroup/EPICS-upgrade#78
Merged
Ticket8297 remove six usage ISISComputingGroup/EPICS-DbChecker#13
Merged
Remove all reference to six ISISComputingGroup/EPICS-LSICorrelator#16
Merged
This was unlinked from pull requests May 17, 2024
Remove all references to Six ISISComputingGroup/EPICS-inst_servers#393
Merged
Remove use of six ISISComputingGroup/EPICS-refl#57
Merged
Remove usage of six ISISComputingGroup/EPICS-IOC_Test_Framework#629
Merged
Remove usage of six ISISComputingGroup/EPICS-DeviceEmulator#176
Merged
Remove usage of six ISISComputingGroup/ibex_gui#1705
Merged
Remove references to six ISISComputingGroup/EPICS-upgrade#78
Merged
Ticket8297 remove six usage ISISComputingGroup/EPICS-DbChecker#13
Merged
@LowriJenkins LowriJenkins removed a link to a pull request May 17, 2024
Remove all reference to six ISISComputingGroup/EPICS-LSICorrelator#16
Merged
2 tasks
@LowriJenkins LowriJenkins added this to the SPRINT_2024_05_02 milestone May 17, 2024
@LowriJenkins LowriJenkins added the 0 label May 17, 2024
@KathrynBaker KathrynBaker moved this to Review in PI_2024_02 May 17, 2024
@LowriJenkins LowriJenkins added the no_release_notes Tickets that do not need release notes, use sparingly! label May 22, 2024
@Chsudeepta
Copy link
Contributor

One linked PR remains open as that module wasn't written by us

@github-project-automation github-project-automation bot moved this from Review to Done in PI_2024_02 May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LowriJenkins LowriJenkins

Labels
0 Friday no_release_notes Tickets that do not need release notes, use sparingly!
Projects
No open projects
PI_2024_02
Status: Done
Milestone
SPRINT_2024_05_23
Development

No branches or pull requests
4 participants
@KathrynBaker @rerpha @LowriJenkins @Chsudeepta