workflows/tests: fix template-injection zizmor info #201306
Merged
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
automerge-skip
samford
commented
Dec 16, 2024
This updates `workflows/tests.yml` to use environment variables to address `template-injection` info from `zizmor`.
samford
force-pushed
the
zizmor-tests-template-injection
branch
from
04036fe to
a97fcdc
Compare
ZhongRuoyu
approved these changes
Dec 16, 2024
daeho-ro
approved these changes
Dec 16, 2024
woodruffw
approved these changes
Dec 16, 2024
|
Now our CI cannot recognize formula name, maybe should roll-back? |
ZhongRuoyu
added a commit
that referenced
this pull request
Dec 16, 2024
The double quoting of formula names is broken after #201306. Let's fix it by moving out the double-quoted formula names to a separate variable. Should fix the failure seen in [1]. [1]: https://github.com/Homebrew/homebrew-core/actions/runs/12345589565/job/34449970508?pr=201322
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?This updates
workflows/tests.ymlto use environment variables to addresstemplate-injectioninfo fromzizmor.