Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: fix quoting of formula names #201330

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The double quoting of formula names is broken after #201306. Let's fix it by moving out the double-quoted formula names to a separate variable. Should fix the failure seen in https://github.com/Homebrew/homebrew-core/actions/runs/12345589565/job/34449970508?pr=201322.

Closes #201328.

The double quoting of formula names is broken after #201306. Let's fix
it by moving out the double-quoted formula names to a separate variable.
Should fix the failure seen in [1].

[1]: https://github.com/Homebrew/homebrew-core/actions/runs/12345589565/job/34449970508?pr=201322
@ZhongRuoyu ZhongRuoyu requested review from MikeMcQuaid and a team as code owners December 16, 2024 05:28
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Dec 16, 2024
@ZhongRuoyu ZhongRuoyu enabled auto-merge December 16, 2024 05:29
@ZhongRuoyu ZhongRuoyu added this pull request to the merge queue Dec 16, 2024
Merged via the queue into master with commit 254209c Dec 16, 2024
21 checks passed
@ZhongRuoyu ZhongRuoyu deleted the workflows-fix-quoting branch December 16, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants