Skip to content

Commit

Permalink
workflows/tests: fix template-injection zizmor info
Browse files Browse the repository at this point in the history
This updates `workflows/tests.yml` to use environment variables to
address `template-injection` info from `zizmor`.
  • Loading branch information
samford committed Dec 16, 2024
1 parent ce01bc7 commit 04036fe
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,10 @@ jobs:
bottles-directory: ${{ env.BOTTLES_DIR }}
cleanup: ${{ matrix.cleanup }}

- run: brew test-bot ${{ needs.setup_tests.outputs.test-bot-formulae-args }}
id: brew-test-bot-formulae
- id: brew-test-bot-formulae
run: brew test-bot $TEST_BOT_FORMULAE_ARGS

Check failure on line 236 in .github/workflows/tests.yml

View workflow job for this annotation

GitHub Actions / workflow_syntax

shellcheck reported issue in this script: SC2086:info:1:15: Double quote to prevent globbing and word splitting
env:
TEST_BOT_FORMULAE_ARGS: ${{ needs.setup_tests.outputs.test-bot-formulae-args }}
working-directory: ${{ env.BOTTLES_DIR }}

- name: Post-build steps
Expand Down Expand Up @@ -355,7 +357,9 @@ jobs:
cleanup: ${{ matrix.cleanup }}
download-bottles: true

- run: brew test-bot ${{ needs.setup_dep_tests.outputs.test-bot-dependents-args }} --testing-formulae="$TESTING_FORMULAE"
- run: brew test-bot $TEST_BOT_DEPENDENTS_ARGS --testing-formulae="$TESTING_FORMULAE"

Check failure on line 360 in .github/workflows/tests.yml

View workflow job for this annotation

GitHub Actions / workflow_syntax

shellcheck reported issue in this script: SC2086:info:1:15: Double quote to prevent globbing and word splitting
env:
TEST_BOT_DEPENDENTS_ARGS: ${{ needs.setup_dep_tests.outputs.test-bot-dependents-args }}
working-directory: ${{ env.BOTTLES_DIR }}

- name: Steps summary and cleanup
Expand Down

0 comments on commit 04036fe

Please sign in to comment.