Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libnfs 6.0.0 #200785

Merged
merged 4 commits into from
Dec 13, 2024
Merged

libnfs 6.0.0 #200785

merged 4 commits into from
Dec 13, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Dec 11, 2024
@bevanjkay bevanjkay force-pushed the bump-libnfs-6.0.0 branch 2 times, most recently from 7052281 to c7b8500 Compare December 11, 2024 11:41
@bevanjkay
Copy link
Member

bevanjkay commented Dec 11, 2024

MacOS only failure.

   libnfs.c:598:36: error: call to undeclared function 'cuserid'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    598 |         rpc_set_username(nfs->rpc, cuserid(NULL));
        |                                    ^
  libnfs.c:598:36: error: incompatible integer to pointer conversion passing 'int' to parameter of type 'const char *' [-Wint-conversion]
    598 |         rpc_set_username(nfs->rpc, cuserid(NULL));
        |                                    ^~~~~~~~~~~~~
  /private/tmp/libnfs-20241211-6183-qh3wql/libnfs-libnfs-6.0.0/include/nfsc/libnfs-raw.h:275:66: note: passing argument to parameter 'username' here
    275 | EXTERN int rpc_set_username(struct rpc_context *rpc, const char *username);
        |    

Using Homebrew krb5 did not solve this issue.

@bevanjkay bevanjkay added the build failure CI fails while building the software label Dec 11, 2024
@daeho-ro
Copy link
Member

@alebcay
Copy link
Member

alebcay commented Dec 11, 2024

Looks like cuserid is not available (anymore?) on macOS. Amusing tidbit from Linux manpage for cuserid(3):

System V has a cuserid() function which uses the real user ID rather than the effective user ID. The cuserid() function was included in the 1988 version of POSIX, but removed from the 1990 version. It was present in SUSv2, but removed in POSIX.1-2001.
[...]
Nobody knows precisely what cuserid() does; avoid it in portable programs. Or avoid it altogether: use getpwuid(geteuid()) instead, if that is what you meant. Do not use cuserid().

@daeho-ro daeho-ro added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Dec 12, 2024
@alebcay alebcay added test failure CI fails while running the test-do block and removed build failure CI fails while building the software labels Dec 12, 2024
@chenrui333
Copy link
Member

the autotools flow has some issue (the built binary has segmented fault), let's switch to use cmake flow then.

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Dec 13, 2024
@chenrui333 chenrui333 removed test failure CI fails while running the test-do block CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Dec 13, 2024
libnfs: add dependency

libnfs: add build patch

libnfs: switch to cmake build

Signed-off-by: Rui Chen <[email protected]>

libnfs: update build and test

Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>

mpd: add libnfs build patch

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed ready to merge PR can be merged once CI is green labels Dec 13, 2024
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Dec 13, 2024
Copy link
Member

@daeho-ro daeho-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 13, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 13, 2024
Merged via the queue into master with commit 9fa6ce8 Dec 13, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-libnfs-6.0.0 branch December 13, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants