Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macos): add RPATH configuration for macOS builds #502

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

chenrui333
Copy link
Contributor

👋 while using cmake for libnfs 6.0.0 release build PR, I found some rpath issue

$ /opt/homebrew/Cellar/libnfs/6.0.0/bin/nfs-ls --help
dyld[84612]: Library not loaded: @rpath/libnfs.16.0.0.dylib
  Referenced from: <D1E1ABB2-ABAB-30FD-BC8D-E797B4E5282E> /opt/homebrew/Cellar/libnfs/6.0.0/bin/nfs-ls
  Reason: no LC_RPATH's found
Abort trap: 6

thus adding some macos cmake build settings.

@sahlberg sahlberg merged commit 796cfb9 into sahlberg:master Dec 13, 2024
7 of 10 checks passed
@chenrui333 chenrui333 deleted the fix-rpath-issue branch December 13, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants