Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g*: Fix Homebrew/NoFileutilsRmrf RuboCop offenses #179162

Merged
merged 39 commits into from
Jul 31, 2024
Merged

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Jul 31, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

issyl0 added 30 commits July 31, 2024 23:25
@issyl0 issyl0 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Jul 31, 2024
@github-actions github-actions bot added long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing labels Jul 31, 2024
@chenrui333 chenrui333 removed long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing labels Jul 31, 2024
@chenrui333 chenrui333 added this pull request to the merge queue Jul 31, 2024
Merged via the queue into master with commit b6b8a1b Jul 31, 2024
20 checks passed
@chenrui333 chenrui333 deleted the g-rubocop-no-rmrf branch July 31, 2024 22:40
@branchvincent
Copy link
Member

We may need to revert these PR's, also seeing postinstall failures with gcc: https://github.com/Homebrew/homebrew-core/actions/runs/10190043249/job/28189185229?pr=179176#step:4:720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants