Merge pull request #179162 from Homebrew/g-rubocop-no-rmrf

g*: Fix `Homebrew/NoFileutilsRmrf` RuboCop offenses

Formula/g/gatsby-cli.rb

@@ -38,7 +38,7 @@ def install
  end
 
  clipboardy_fallbacks_dir = node_modules/"clipboardy/fallbacks"
- clipboardy_fallbacks_dir.rmtree # remove pre-built binaries
+ rm_r(clipboardy_fallbacks_dir) # remove pre-built binaries
  if OS.linux?
  linux_dir = clipboardy_fallbacks_dir/"linux"
  linux_dir.mkpath

Formula/g/gcc.rb

@@ -163,11 +163,11 @@ def install
  # Rename man7.
  man7.glob("*.7") { |file| add_suffix file, version_suffix }
  # Even when we disable building info pages some are still installed.
- info.rmtree
+ rm_r(info)
 
  # Work around GCC install bug
  # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105664
- rm_rf bin.glob("*-gcc-tmp")
+ rm_r(bin.glob("*-gcc-tmp"))
  end
 
  def add_suffix(file, suffix)
@@ -201,7 +201,7 @@ def post_install
  specs = libgcc/"specs"
  ohai "Creating the GCC specs file: #{specs}"
  specs_orig = Pathname.new("#{specs}.orig")
- rm_f [specs_orig, specs]
+ rm([specs_orig, specs])
 
  system_header_dirs = ["#{HOMEBREW_PREFIX}/include"]
 

Formula/g/gcc@10.rb

@@ -125,11 +125,11 @@ def install
  # Rename man7.
  Dir.glob(man7/"*.7") { |file| add_suffix file, version_suffix }
  # Even when we disable building info pages some are still installed.
- info.rmtree
+ rm_r(info)
 
  # Work around GCC install bug
  # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105664
- rm_rf Dir[bin/"*-gcc-tmp"]
+ rm_r(Dir[bin/"*-gcc-tmp"])
  end
 
  def add_suffix(file, suffix)
@@ -163,7 +163,7 @@ def post_install
  specs = libgcc/"specs"
  ohai "Creating the GCC specs file: #{specs}"
  specs_orig = Pathname.new("#{specs}.orig")
- rm_f [specs_orig, specs]
+ rm([specs_orig, specs])
 
  system_header_dirs = ["#{HOMEBREW_PREFIX}/include"]
 

Formula/g/gcc@11.rb

@@ -126,11 +126,11 @@ def install
  # Rename man7.
  man7.glob("*.7") { |file| add_suffix file, version.major }
  # Even when we disable building info pages some are still installed.
- info.rmtree
+ rm_r(info)
 
  # Work around GCC install bug
  # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105664
- rm_rf bin.glob("*-gcc-tmp")
+ rm_r(bin.glob("*-gcc-tmp"))
  end
 
  def add_suffix(file, suffix)
@@ -164,7 +164,7 @@ def post_install
  specs = libgcc/"specs"
  ohai "Creating the GCC specs file: #{specs}"
  specs_orig = Pathname.new("#{specs}.orig")
- rm_f [specs_orig, specs]
+ rm([specs_orig, specs])
 
  system_header_dirs = ["#{HOMEBREW_PREFIX}/include"]
 

Formula/g/gcc@12.rb

@@ -132,11 +132,11 @@ def install
  # Rename man7.
  man7.glob("*.7") { |file| add_suffix file, version.major }
  # Even when we disable building info pages some are still installed.
- info.rmtree
+ rm_r(info)
 
  # Work around GCC install bug
  # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105664
- rm_rf bin.glob("*-gcc-tmp")
+ rm_r(bin.glob("*-gcc-tmp"))
  end
 
  def add_suffix(file, suffix)
@@ -170,7 +170,7 @@ def post_install
  specs = libgcc/"specs"
  ohai "Creating the GCC specs file: #{specs}"
  specs_orig = Pathname.new("#{specs}.orig")
- rm_f [specs_orig, specs]
+ rm([specs_orig, specs])
 
  system_header_dirs = ["#{HOMEBREW_PREFIX}/include"]
 

Formula/g/gcc@13.rb

@@ -129,11 +129,11 @@ def install
  # Rename man7.
  man7.glob("*.7") { |file| add_suffix file, version.major }
  # Even when we disable building info pages some are still installed.
- info.rmtree
+ rm_r(info)
 
  # Work around GCC install bug
  # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105664
- rm_rf bin.glob("*-gcc-tmp")
+ rm_r(bin.glob("*-gcc-tmp"))
  end
 
  def add_suffix(file, suffix)
@@ -167,7 +167,7 @@ def post_install
  specs = libgcc/"specs"
  ohai "Creating the GCC specs file: #{specs}"
  specs_orig = Pathname.new("#{specs}.orig")
- rm_f [specs_orig, specs]
+ rm([specs_orig, specs])
 
  system_header_dirs = ["#{HOMEBREW_PREFIX}/include"]
 

Formula/g/gcc@5.rb

@@ -145,7 +145,7 @@ def install
  # Rename man7.
  Dir.glob(man7/"*.7") { |file| add_suffix file, version_suffix }
  # Even when we disable building info pages some are still installed.
- info.rmtree
+ rm_r(info)
  end
 
  def add_suffix(file, suffix)
@@ -179,7 +179,7 @@ def post_install
  specs = libgcc/"specs"
  ohai "Creating the GCC specs file: #{specs}"
  specs_orig = Pathname.new("#{specs}.orig")
- rm_f [specs_orig, specs]
+ rm([specs_orig, specs])
 
  system_header_dirs = ["#{HOMEBREW_PREFIX}/include"]
 

Formula/g/gcc@6.rb

@@ -151,7 +151,7 @@ def install
  # Rename man7.
  Dir.glob(man7/"*.7") { |file| add_suffix file, version_suffix }
  # Even when we disable building info pages some are still installed.
- info.rmtree
+ rm_r(info)
  end
 
  def add_suffix(file, suffix)
@@ -185,7 +185,7 @@ def post_install
  specs = libgcc/"specs"
  ohai "Creating the GCC specs file: #{specs}"
  specs_orig = Pathname.new("#{specs}.orig")
- rm_f [specs_orig, specs]
+ rm([specs_orig, specs])
 
  system_header_dirs = ["#{HOMEBREW_PREFIX}/include"]
 

Formula/g/gcc@7.rb

@@ -135,7 +135,7 @@ def install
  # Rename man7.
  Dir.glob(man7/"*.7") { |file| add_suffix file, version_suffix }
  # Even when we disable building info pages some are still installed.
- info.rmtree
+ rm_r(info)
  end
 
  def add_suffix(file, suffix)
@@ -169,7 +169,7 @@ def post_install
  specs = libgcc/"specs"
  ohai "Creating the GCC specs file: #{specs}"
  specs_orig = Pathname.new("#{specs}.orig")
- rm_f [specs_orig, specs]
+ rm([specs_orig, specs])
 
  system_header_dirs = ["#{HOMEBREW_PREFIX}/include"]
 

Formula/g/gcc@8.rb

@@ -143,7 +143,7 @@ def install
  # Rename man7.
  Dir.glob(man7/"*.7") { |file| add_suffix file, version_suffix }
  # Even when we disable building info pages some are still installed.
- info.rmtree
+ rm_r(info)
  end
 
  def add_suffix(file, suffix)
@@ -177,7 +177,7 @@ def post_install
  specs = libgcc/"specs"
  ohai "Creating the GCC specs file: #{specs}"
  specs_orig = Pathname.new("#{specs}.orig")
- rm_f [specs_orig, specs]
+ rm([specs_orig, specs])
 
  system_header_dirs = ["#{HOMEBREW_PREFIX}/include"]
 

Formula/g/gcc@9.rb

@@ -124,11 +124,11 @@ def install
  # Rename man7.
  Dir.glob(man7/"*.7") { |file| add_suffix file, version_suffix }
  # Even when we disable building info pages some are still installed.
- info.rmtree
+ rm_r(info)
 
  # Work around GCC install bug
  # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105664
- rm_rf Dir[bin/"*-gcc-tmp"]
+ rm_r(Dir[bin/"*-gcc-tmp"])
  end
 
  def post_install
@@ -155,7 +155,7 @@ def post_install
  specs = libgcc/"specs"
  ohai "Creating the GCC specs file: #{specs}"
  specs_orig = Pathname.new("#{specs}.orig")
- rm_f [specs_orig, specs]
+ rm([specs_orig, specs])
 
  system_header_dirs = ["#{HOMEBREW_PREFIX}/include"]
 

Formula/g/geckodriver.rb

@@ -55,9 +55,9 @@ def install
  %w[webdriver mozbase].each do |r|
  (buildpath/"staging").install resource(r)
  mv buildpath/"staging"/"testing"/r, buildpath/"testing"
- rm_rf buildpath/"staging"/"testing"
+ rm_r(buildpath/"staging"/"testing")
  end
- rm_rf buildpath/"staging"
+ rm_r(buildpath/"staging")
  (buildpath/"testing"/"geckodriver").install resource("Cargo.lock")
  end
 

Formula/g/geph4.rb

@@ -28,7 +28,7 @@ def install
  ENV["OPENSSL_DIR"] = Formula["openssl@3"].opt_prefix
  ENV["OPENSSL_NO_VENDOR"] = "1"
 
- (buildpath/".cargo").rmtree
+ rm_r(buildpath/".cargo")
  system "cargo", "install", *std_cargo_args
  end
 

Formula/g/ghostscript.rb

@@ -71,7 +71,7 @@ class Ghostscript < Formula
  def install
  # Delete local vendored sources so build uses system dependencies
  libs = %w[expat freetype jbig2dec jpeg lcms2mt libpng openjpeg tiff zlib]
- libs.each { |l| (buildpath/l).rmtree }
+ libs.each { |l| rm_r(buildpath/l) }
 
  configure = build.head? ? "./autogen.sh" : "./configure"
  system configure, *std_configure_args,

Formula/g/git.rb

@@ -160,7 +160,7 @@ def install
  # purged by Homebrew's post-install cleaner because that doesn't check
  # "Library" directories. It is however pointless to keep around as it
  # only contains the perllocal.pod installation file.
- rm_rf prefix/"Library/Perl"
+ rm_r(prefix/"Library/Perl")
 
  # Set the macOS keychain credential helper by default
  # (as Apple's CLT's git also does this).

Formula/g/glassfish.rb

@@ -29,7 +29,7 @@ class Glassfish < Formula
 
  def install
  # Remove all windows files
- rm_rf Dir["bin/*.bat", "glassfish/bin/*.bat"]
+ rm_r(Dir["bin/*.bat", "glassfish/bin/*.bat"])
 
  libexec.install Dir["*"]
  bin.install Dir["#{libexec}/bin/*"]

Formula/g/glibc.rb

@@ -195,15 +195,15 @@ def install
  include /etc/ld.so.conf
  EOS
 
- rm_f etc/"ld.so.cache"
+ rm(etc/"ld.so.cache")
  ensure
  # Delete bootstrap binaries after build is finished.
- rm_rf bootstrap_dir
+ rm_r(bootstrap_dir)
  end
 
  def post_install
  # Rebuild ldconfig cache
- rm_f etc/"ld.so.cache"
+ rm(etc/"ld.so.cache")
  system sbin/"ldconfig"
 
  # Compile locale definition files

Formula/g/gnutls.rb

@@ -54,7 +54,7 @@ def install
  end
 
  def post_install
- rm_f pkgetc/"cert.pem"
+ rm(pkgetc/"cert.pem")
  pkgetc.install_symlink Formula["ca-certificates"].pkgetc/"cert.pem"
  end
 

Formula/g/go-boring.rb

@@ -35,15 +35,15 @@ def install
  system "./make.bash", "--no-clean"
  end
 
- (buildpath/"pkg/obj").rmtree
+ rm_r(buildpath/"pkg/obj")
  libexec.install Dir["*"]
  bin.install_symlink Dir[libexec/"bin/go*"]
 
  system bin/"go", "install", "-race", "std"
 
  # Remove useless files.
  # Breaks patchelf because folder contains weird debug/test files
- Dir.glob(libexec/"**/testdata").each { |testdata| rm_rf testdata }
+ Dir.glob(libexec/"**/testdata").each { |testdata| rm_r(testdata) }
  end
 
  test do

Formula/g/go.rb

@@ -73,17 +73,17 @@ def install
  with_env(CC: "cc", CXX: "c++") { system "./make.bash" }
  end
 
- rm_rf "gobootstrap" # Bootstrap not required beyond compile.
+ rm_r("gobootstrap") # Bootstrap not required beyond compile.
  libexec.install Dir["*"]
  bin.install_symlink Dir[libexec/"bin/go*"]
 
  system bin/"go", "install", "std", "cmd"
 
  # Remove useless files.
  # Breaks patchelf because folder contains weird debug/test files
- (libexec/"src/debug/elf/testdata").rmtree
+ rm_r(libexec/"src/debug/elf/testdata")
  # Binaries built for an incompatible architecture
- (libexec/"src/runtime/pprof/testdata").rmtree
+ rm_r(libexec/"src/runtime/pprof/testdata")
  end
 
  test do

Formula/g/go@1.16.rb

@@ -33,17 +33,17 @@ def install
  system "./make.bash", "--no-clean"
  end
 
- (buildpath/"pkg/obj").rmtree
+ rm_r(buildpath/"pkg/obj")
  libexec.install Dir["*"]
  bin.install_symlink Dir[libexec/"bin/go*"]
 
  system bin/"go", "install", "-race", "std"
 
  # Remove useless files.
  # Breaks patchelf because folder contains weird debug/test files
- (libexec/"src/debug/elf/testdata").rmtree
+ rm_r(libexec/"src/debug/elf/testdata")
  # Binaries built for an incompatible architecture
- (libexec/"src/runtime/pprof/testdata").rmtree
+ rm_r(libexec/"src/runtime/pprof/testdata")
  end
 
  test do

Formula/g/go@1.17.rb

@@ -35,17 +35,17 @@ def install
  system "./make.bash", "--no-clean"
  end
 
- (buildpath/"pkg/obj").rmtree
+ rm_r(buildpath/"pkg/obj")
  libexec.install Dir["*"]
  bin.install_symlink Dir[libexec/"bin/go*"]
 
  system bin/"go", "install", "-race", "std"
 
  # Remove useless files.
  # Breaks patchelf because folder contains weird debug/test files
- (libexec/"src/debug/elf/testdata").rmtree
+ rm_r(libexec/"src/debug/elf/testdata")
  # Binaries built for an incompatible architecture
- (libexec/"src/runtime/pprof/testdata").rmtree
+ rm_r(libexec/"src/runtime/pprof/testdata")
  end
 
  test do

Formula/g/go@1.18.rb

@@ -34,17 +34,17 @@ def install
  system "./make.bash", "--no-clean"
  end
 
- (buildpath/"pkg/obj").rmtree
+ rm_r(buildpath/"pkg/obj")
  libexec.install Dir["*"]
  bin.install_symlink Dir[libexec/"bin/go*"]
 
  system bin/"go", "install", "-race", "std"
 
  # Remove useless files.
  # Breaks patchelf because folder contains weird debug/test files
- (libexec/"src/debug/elf/testdata").rmtree
+ rm_r(libexec/"src/debug/elf/testdata")
  # Binaries built for an incompatible architecture
- (libexec/"src/runtime/pprof/testdata").rmtree
+ rm_r(libexec/"src/runtime/pprof/testdata")
  end
 
  test do