Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a*: Fix Homebrew/NoFileutilsRmrf RuboCop offenses #178118

Merged
merged 19 commits into from
Jul 31, 2024

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Jul 22, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@issyl0 issyl0 added the CI-no-bottles Merge without publishing bottles label Jul 22, 2024
@github-actions github-actions bot added the long build Set a long timeout for formula testing label Jul 22, 2024
@p-linnane
Copy link
Member

apache-archiva link can be updated to https://www.apache.org/dist/archiva/2.2.10/binaries/apache-archiva-2.2.10-bin.zip.

@p-linnane p-linnane added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jul 22, 2024
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jul 22, 2024
@issyl0 issyl0 force-pushed the batch-one-rubocop-fileutils-rmrf branch 2 times, most recently from 0ed0610 to 48cdf83 Compare July 22, 2024 21:23
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jul 22, 2024
@issyl0 issyl0 force-pushed the batch-one-rubocop-fileutils-rmrf branch from 48cdf83 to 8e30f53 Compare July 22, 2024 21:27
@issyl0
Copy link
Member Author

issyl0 commented Jul 23, 2024

apache-archiva link can be updated to https://www.apache.org/dist/archiva/2.2.10/binaries/apache-archiva-2.2.10-bin.zip.

FormulaAudit/Urls doesn't like this, so I've kept it as is and it's continually failing to download. Maybe the URL audit should skip deprecated formulae?

@p-linnane
Copy link
Member

FormulaAudit/Urls doesn't like this, so I've kept it as is and it's continually failing to download. Maybe the URL audit should skip deprecated formulae?

Yeah the original link is just a redirect to Apache's deprecation page now. Thoughts on skipping URL audits for deprecated/disabled formula @Homebrew/core?

@Bo98
Copy link
Member

Bo98 commented Jul 23, 2024

That actually looks like a brew bug really. The mirror works fine but it's clearly not detecting it properly.

@Bo98
Copy link
Member

Bo98 commented Jul 23, 2024

Homebrew/brew#17829

You can revert the URL change to apache-archiva with that.

@issyl0
Copy link
Member Author

issyl0 commented Jul 23, 2024

Thanks, Bo!

@issyl0 issyl0 force-pushed the batch-one-rubocop-fileutils-rmrf branch 2 times, most recently from 7126e1b to 9a6286e Compare July 24, 2024 15:45
@issyl0
Copy link
Member Author

issyl0 commented Jul 24, 2024

I split apt-dater into its own PR because the build failures were unrelated, and the debug files we were trying to remove in arrayfire are no longer included. Hopefully this goes green now. 🤞🏻

@issyl0 issyl0 enabled auto-merge July 24, 2024 16:34
@issyl0 issyl0 added CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. and removed CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-bottles Merge without publishing bottles long build Set a long timeout for formula testing labels Jul 31, 2024
@issyl0 issyl0 force-pushed the batch-one-rubocop-fileutils-rmrf branch from 9a6286e to ae154d2 Compare July 31, 2024 22:02
@github-actions github-actions bot added the long build Set a long timeout for formula testing label Jul 31, 2024
@issyl0 issyl0 added this pull request to the merge queue Jul 31, 2024
Merged via the queue into master with commit f5e864e Jul 31, 2024
18 checks passed
@issyl0 issyl0 deleted the batch-one-rubocop-fileutils-rmrf branch July 31, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. long build Set a long timeout for formula testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants