Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm 18.1.4 #165206

Merged
merged 32 commits into from Apr 23, 2024
Merged

llvm 18.1.4 #165206

merged 32 commits into from Apr 23, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` long build Needs CI-long-timeout labels Mar 6, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 6, 2024
@ZhongRuoyu ZhongRuoyu added CI-long-timeout Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-linux-self-hosted Build on Linux self-hosted runner labels Mar 6, 2024
@Porkepix
Copy link
Contributor

Porkepix commented Mar 6, 2024

Second time Linux self-hosted runner seems to have difficulties picking-up the job, curious.

@lukeshingles
Copy link

Is there a reason not to compile with -DLIBCXX_ENABLE_PARALLEL_ALGORITHMS=YES ? I would really like to have parallel algorithms available.

@poyaoc97
Copy link

poyaoc97 commented Mar 6, 2024

Is there a reason not to compile with -DLIBCXX_ENABLE_PARALLEL_ALGORITHMS=YES ? I would really like to have parallel algorithms available.

That option was removed in llvm/llvm-project@e7e371188513348e493ed8afb1. Nowadays, you can either add -fexperimental-library to compile and link flags or define _LIBCPP_ENABLE_EXPERIMENTAL and link against libc++experimental.a (https://releases.llvm.org/18.1.0/projects/libcxx/docs/UsingLibcxx.html#enabling-experimental-c-library-features).

However, -DLIBCXX_INSTALL_MODULES=ON is the options that I would like to add.

@poyaoc97
Copy link

poyaoc97 commented Mar 6, 2024

However, -DLIBCXX_INSTALL_MODULES=ON is the options that I would like to add.

-DLIBCXX_PSTL_CPU_BACKEND=libdispatch for macOS is also a nice addition! which is also in the CMake cache for testing: https://github.com/llvm/llvm-project/blob/llvmorg-18.1.0/libcxx/cmake/caches/Apple.cmake#L10.

@cho-m cho-m added the test failure CI fails while running the test-do block label Mar 6, 2024
@github-actions github-actions bot removed the CI-long-timeout Use longer GitHub Actions CI timeout. label Mar 6, 2024
Copy link
Contributor

github-actions bot commented Mar 9, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Mar 9, 2024
@github-actions github-actions bot closed this Mar 10, 2024
@chenrui333 chenrui333 reopened this Mar 10, 2024
@chenrui333 chenrui333 added the in progress Stale bot should stay away label Mar 10, 2024
@chenrui333 chenrui333 mentioned this pull request Mar 10, 2024
@carlocab carlocab added CI-long-timeout Use longer GitHub Actions CI timeout. and removed stale No recent activity labels Mar 11, 2024
@carlocab carlocab changed the title llvm 18.1.0 llvm 18.1.1 Mar 11, 2024
@carlocab carlocab force-pushed the bump-llvm-18.1.0 branch 2 times, most recently from a5bbbbb to 013b94a Compare March 11, 2024 07:58
@carlocab carlocab mentioned this pull request Mar 11, 2024
@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 23, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 23, 2024
Merged via the queue into master with commit 8da7500 Apr 23, 2024
14 checks passed
@BrewTestBot BrewTestBot deleted the bump-llvm-18.1.0 branch April 23, 2024 01:19
@ChrisThrasher
Copy link
Contributor

I've been following this PR thread since the beginning and just wanted to say that I really appreciate the Homebrew team for working hard to make this happen. :)

@chenrui333
Copy link
Member

csound arm bottles would be covered with #169814

@fingolfin
Copy link

This update broke llvm for me:

$ /opt/homebrew/opt/llvm/bin/clang
dyld[97666]: Library not loaded: '/opt/homebrew/opt/z3/lib/libz3.4.12.dylib'
  Referenced from: '/opt/homebrew/Cellar/llvm/17.0.6_1/lib/libLLVM.dylib'
  Reason: tried: '/opt/homebrew/opt/z3/lib/libz3.4.12.dylib' (no such file), '/usr/local/lib/libz3.4.12.dylib' (no such file), '/usr/lib/libz3.4.12.dylib' (no such file), '/opt/homebrew/Cellar/z3/4.13.0/lib/libz3.4.12.dylib' (no such file), '/usr/local/lib/libz3.4.12.dylib' (no such file), '/usr/lib/libz3.4.12.dylib' (no such file)
Abort trap: 6

However this is on macOS 12.7.4 (on an M1 mac) so perhaps that's because I am on an unsupported OS?

@Bo98
Copy link
Member

Bo98 commented Apr 29, 2024

llvm/17.0.6_1

Doesn't look like you upgraded LLVM. This PR ships 18.1.4

@fingolfin
Copy link

Apologies for being unclear: this PR updated z3. As a result all older LLVM versions (which I need and which homebrew lists as llvm@15 etc.) are broken as they were still built against the older z3. So I guess they either all need to be rebuilt against the newer z3; or as a workaround perhaps I can downgrade z3 (but then presumably can't use llvm 18)

@carlocab
Copy link
Member

Do brew update then brew reinstall llvm@17 (or whichever version you need).

@Bo98
Copy link
Member

Bo98 commented Apr 29, 2024

All versioned LLVM we ship don't link to z3. This includes llvm@17.

We only enable z3 for the latest llvm.

You're currently using an outdated unversioned llvm (so you're not using llvm@17 yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. in progress Stale bot should stay away long build Needs CI-long-timeout no long build conflict Do not allow merging other pull requests when files conflict with this one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet