Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/triage: allow_any_match when CI-linux-self-hosted #165366

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Mar 7, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

I added allow_any_match to long build Set a long timeout for formula testing in #164290 and it seems to work, e.g.

In case of llvm, adding allow_any_match to CI-linux-self-hosted Build on Linux self-hosted runner should allow automatically labelling that too.


I may hold off on adding this to CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. as adding some version detection to action script will help avoid labeling revision bump PRs.

@cho-m cho-m requested review from MikeMcQuaid and a team as code owners March 7, 2024 14:33
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Mar 7, 2024
Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @cho-m!

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@cho-m cho-m added this pull request to the merge queue Mar 7, 2024
Merged via the queue into master with commit ab284f5 Mar 7, 2024
17 checks passed
@cho-m cho-m deleted the triage-Linux-allow_any_match branch March 7, 2024 19:03
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request outdated PR was locked due to age workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants