-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: only block cask install on Linux #18808
Conversation
733c151
to
22d6b09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense so far! Probably want to make --cask
explicitly required on Linux until this is (much) further along?
You mean for |
@SMillerDev Ok, as long as |
I'll do an extra check for those specific ones. What do you think should happen to |
I think probably require |
Tested this in a codespace, it has the same result, but a different output. Before this PR: linuxbrew@codespaces-069e0c:~/.linuxbrew/Homebrew$ brew install google-chrome
==> Downloading https://formulae.brew.sh/api/formula.jws.json
Warning: No available formula with the name "google-chrome". Did you mean google-benchmark?
==> Searching for similarly named formulae...
==> Formulae
google-benchmark
To install google-benchmark, run:
brew install google-benchmark After this PR: linuxbrew@codespaces-069e0c:~/.linuxbrew/Homebrew$ brew install google-chrome
==> Downloading https://formulae.brew.sh/api/cask.jws.json
##O=# #
Error: macOS is required for this software. |
@SMillerDev What about I think the prior behaviour is better on Linux for now, sorry, but I think if you added |
I'll reinstate that. Seems like I was too eager with the CLI changes. After that and fixing the tests, are you fine to merge this while I work on the font installing? Or you'd rather bundle it and merge in one go? |
@SMillerDev I'm game to merge smaller/incremental changes here, yeh 👍🏻 |
22d6b09
to
b0df86e
Compare
Okay, with this latest change that behaviour should be reinstated. |
3b3a7bb
to
526d311
Compare
9e5bdfe
to
1d907ca
Compare
1d907ca
to
cb23433
Compare
Looks like all checks are green and the behavior was restored as requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @SMillerDev!
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This is the first step to allowing font (and later binary) casks to be installable on Linux.
TODO:
brew search --cask X
brew info --cask X