feat: allow font install on linux #18874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
force-pushed
the
feat/cask/font_install
branch
3 times, most recently
from
801829e to
e5c2c8c
Compare
SMillerDev
changed the title
SMillerDev
force-pushed
the
feat/cask/font_install
branch
from
e5c2c8c to
d1b5f68
Compare
Member
Author
|
Installing fonts now works, although it is still installing in the macOS location. I can't get the DEFAULTS to work. |
SMillerDev
force-pushed
the
feat/cask/font_install
branch
3 times, most recently
from
99e0454 to
ed30ba7
Compare
SMillerDev
force-pushed
the
feat/cask/font_install
branch
from
ed30ba7 to
378ff7c
Compare
SMillerDev
commented
Jan 7, 2025
dduugg
reviewed
Jan 7, 2025
dduugg
reviewed
Jan 7, 2025
SMillerDev
force-pushed
the
feat/cask/font_install
branch
3 times, most recently
from
6e8fc52 to
75ac2b5
Compare
dduugg
reviewed
Jan 9, 2025
dduugg
reviewed
Jan 9, 2025
dduugg
reviewed
Jan 9, 2025
dduugg
reviewed
Jan 9, 2025
dduugg
reviewed
Jan 9, 2025
dduugg
reviewed
Jan 9, 2025
Member
Author
|
Thanks for the pointers @dduugg ! |
dduugg
reviewed
Jan 10, 2025
SMillerDev
force-pushed
the
feat/cask/font_install
branch
2 times, most recently
from
a438928 to
76c1313
Compare
Member
Author
|
It seems to work now, thanks so much for the help @dduugg ! |
MikeMcQuaid
approved these changes
Jan 16, 2025
Member
MikeMcQuaid
left a comment
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Makes sense! Happy to merge this when you are.
SMillerDev
force-pushed
the
feat/cask/font_install
branch
from
5a08f5b to
31b6d41
Compare
Apply suggestions from code review Co-authored-by: Douglas Eichelberger <[email protected]> feat: add linux appdir Apply suggestions from code review Co-authored-by: Douglas Eichelberger <[email protected]>
SMillerDev
force-pushed
the
feat/cask/font_install
branch
2 times, most recently
from
1a8dea6 to
9f9bfb4
Compare
SMillerDev
force-pushed
the
feat/cask/font_install
branch
from
9f9bfb4 to
32b9afd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?This should disable quarantine on Linux, allow installing fonts and set a location for the fonts. Marking this as draft until I've had a moment to test it.
Waiting for #18808 to be merged