Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow/tests: move Docker tests to docker.yml #18168

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

It's more intuitive that way.

Resolves #17827 (comment).

Co-authored-by: Carlo Cabrera <[email protected]>
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for cleanup @ZhongRuoyu!

A nice follow-up would be to migrate to using https://github.com/docker/build-push-action

I can DM you how Workbrew uses this if that'd be useful but TL;DR you can get better caching and push with less conditional logic required.

@MikeMcQuaid MikeMcQuaid merged commit abc0584 into master Aug 26, 2024
28 checks passed
@MikeMcQuaid MikeMcQuaid deleted the docker-tests branch August 26, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants