Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/docker: use docker/build-push-action to build images #18175

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This allows us to use Docker's build cache across workflow runs.

Follow-up to #18168 (comment).

@ZhongRuoyu
Copy link
Member Author

docker/build-push-action needs to be whitelisted: https://github.com/Homebrew/brew/actions/runs/10571630424

.github/workflows/docker.yml Outdated Show resolved Hide resolved
@MikeMcQuaid
Copy link
Member

docker/build-push-action needs to be whitelisted: Homebrew/brew/actions/runs/10571630424

Done! Do we want/need to use https://github.com/docker/setup-buildx-action or https://github.com/docker/login-action?

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, thanks @ZhongRuoyu!

.github/workflows/docker.yml Outdated Show resolved Hide resolved
.github/workflows/docker.yml Show resolved Hide resolved
@carlocab
Copy link
Member

ERROR: Cache export is not supported for the docker driver.
Switch to a different driver, or turn on the containerd image store, and try again.
Learn more at https://docs.docker.com/go/build-cache-backends/

@ZhongRuoyu
Copy link
Member Author

ERROR: Cache export is not supported for the docker driver.
Switch to a different driver, or turn on the containerd image store, and try again.
Learn more at https://docs.docker.com/go/build-cache-backends/

We probably need Docker Buildx for this: https://github.com/docker/setup-buildx-action. @MikeMcQuaid will you whitelist this too?

@MikeMcQuaid
Copy link
Member

We probably need Docker Buildx for this: docker/setup-buildx-action. @MikeMcQuaid will you whitelist this too?

Done!

@ZhongRuoyu ZhongRuoyu marked this pull request as draft August 27, 2024 09:15
ZhongRuoyu and others added 2 commits August 27, 2024 18:29
This allows us to use Docker's build cache across workflow runs.

Co-authored-by: Carlo Cabrera <[email protected]>
@ZhongRuoyu ZhongRuoyu force-pushed the docker-build-push-action branch 2 times, most recently from 5d67b95 to d1173f4 Compare August 27, 2024 10:32
@ZhongRuoyu ZhongRuoyu marked this pull request as ready for review August 27, 2024 11:40
@MikeMcQuaid
Copy link
Member

Thanks @ZhongRuoyu!

@ZhongRuoyu ZhongRuoyu merged commit 80c04e2 into master Aug 27, 2024
28 checks passed
@ZhongRuoyu ZhongRuoyu deleted the docker-build-push-action branch August 27, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants