Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Color Picker to DynText Modifier #417

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

DoobesURU
Copy link
Contributor

Small addition to the Localized/DynText modifier to add a color picker for the font color in the font options. Utilizes the existing font_color def in properties.

* Adds a color picker to the UI to choose font color for DynText
@DoobesURU DoobesURU marked this pull request as draft August 23, 2024 19:49
@DoobesURU
Copy link
Contributor Author

Just realized export isn't working just yet, so converted to draft until I do. 😊

@DoobesURU
Copy link
Contributor Author

Looks like it wasn't anything I did, but an issue with Korman itself: #418

@DoobesURU DoobesURU marked this pull request as ready for review August 30, 2024 15:41
Copy link
Member

@Hoikas Hoikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready to go?

@DoobesURU
Copy link
Contributor Author

Is this ready to go?

Should be! Just one line of code to add a color picker below the other two font options.

@Hoikas Hoikas merged commit 4a0bbf3 into H-uru:master Sep 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants