Skip to content

Disable writing page index in float array benchmark #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025
Merged

Disable writing page index in float array benchmark #543

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
526fa35
Disable writing page index in float array benchmark
adamreeve Jul 8, 2025
f61cb44
Add comment with issue link
adamreeve Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions csharp.benchmark/FloatArrayTimeSeriesRead.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.IO;
using System.Linq;
using System.Threading.Tasks;
using Apache.Arrow;
Expand All @@ -28,7 +27,12 @@ public FloatArrayTimeSeriesRead()
_allObjectIds = dates.SelectMany(d => objectIds).ToArray();
_allValues = dates.SelectMany((d, i) => values[i]).ToArray();

using (var fileWriter = new ParquetFileWriter(Filename, CreateFloatArrayColumns(), Compression.Snappy))
using var writerPropertiesBuilder = new WriterPropertiesBuilder();
// Disable writing page indexes to work around https://github.com/apache/arrow/issues/47027
using var writerProperties = writerPropertiesBuilder
.DisableWritePageIndex()
Copy link
Contributor

@marcin-krystianc marcin-krystianc Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add comment with an explanation, that this is a workaround for apache/arrow#47027

Copy link
Contributor Author

@adamreeve adamreeve Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I've added a comment now.

Although after looking into this more, I think we might want to override this in the default writer properties before releasing 20.0.0 as this could affect anyone writing lists/arrays with a lot of rows in one row group.

.Build();
using (var fileWriter = new ParquetFileWriter(Filename, CreateFloatArrayColumns(), writerProperties))
{
using var rowGroupWriter = fileWriter.AppendRowGroup();

Expand Down