Disable writing page index in float array benchmark #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to work around apache/arrow#47027
| using (var fileWriter = new ParquetFileWriter(Filename, CreateFloatArrayColumns(), Compression.Snappy)) | ||
| using var writerPropertiesBuilder = new WriterPropertiesBuilder(); | ||
| using var writerProperties = writerPropertiesBuilder | ||
| .DisableWritePageIndex() |
Contributor
There was a problem hiding this comment.
I think we should add comment with an explanation, that this is a workaround for apache/arrow#47027
Contributor
Author
There was a problem hiding this comment.
Good point, I've added a comment now.
Although after looking into this more, I think we might want to override this in the default writer properties before releasing 20.0.0 as this could affect anyone writing lists/arrays with a lot of rows in one row group.
marcin-krystianc
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #542