Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark and light classic stylesheets. #13772

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

MisterMakerNL
Copy link
Contributor

@MisterMakerNL MisterMakerNL commented May 1, 2024

I just tried to copy 1:1 the no-stylesheet theme, but in dark.
It's not perfect but that's QT. :)
Overlay still seems to need some work.
This also ads the icons that are used in default freecad, currently it seems that all theme icons are based on mac-icons.
latest update:
853689e4c125b16e

image
image
image

Added the new QSS file with images
@github-actions github-actions bot added the Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD label May 1, 2024
@PaddleStroke
Copy link
Contributor

Interesting. I seem to recall that Qt 6.5 was implementing a dark mode that would make things simpler. Is that taking advantage of that? Are we even using 6.5 btw?

@MisterMakerNL
Copy link
Contributor Author

@PaddleStroke this would indeed work very well with the 6.5 functionality as I understand Qt 6.5 can detect the dark style of windows and apply a dark theme. But it doesn't have a good dark theme out of the box.
But would be more logical, if it did so maybe they have added one. QT docs aren't really complete most of the time.

@MisterMakerNL
Copy link
Contributor Author

Updated, already better than currently included stylesheets! So pretty much ready, just going to spend some time fixing up overlay.

image

@MisterMakerNL
Copy link
Contributor Author

Btw if people think this is not modern or ugly because of the purple gradients, then we should fix that in no-stylesheet too and also here. This is a black version of no-stylesheet including the not so popular gradients. (although the menu gradients are adjusted to the white text.)

Might be a good idea to adjust the background color to the same gradient as in the menu like this:
image
I updated the Qsint group which now looks like original.
I also fixed the overlay a bit. worked around the properties panel click true issue by making the background 0.01% transparency.
image

#13351

This light theme is basicallyt exactly no-stylesheet.
@MisterMakerNL MisterMakerNL changed the title New Dark style based on default Freecad. Dark and light classic stylesheets. May 12, 2024
@MisterMakerNL
Copy link
Contributor Author

Added light theme
image

@MisterMakerNL
Copy link
Contributor Author

Added overlay fixes:
image

@MisterMakerNL MisterMakerNL marked this pull request as ready for review May 12, 2024 22:42
@MisterMakerNL
Copy link
Contributor Author

It probably has some tiny bugs, I see one with the treeview having black arrows.
But it's still a lot better than current situation, so this can be reviewed

@chennes
Copy link
Member

chennes commented May 13, 2024

Are these meant to replace the stylesheets used in the "Dark" and "Light" preference packs?

@MisterMakerNL
Copy link
Contributor Author

Are these meant to replace the stylesheets used in the "Dark" and "Light" preference packs?

Yes, I'll have a look at making the preference packs too.

@chennes
Copy link
Member

chennes commented May 13, 2024

@FreeCAD/design-working-group can you please take a look?

@pierreporte
Copy link

@chennes Looking at the screenshots, they look pretty decent. The only problem is the background but it has already been discussed: needs #13980 to be fixed before. The themes may not be perfect but they are good enough IMO and they can always be improved.

@MisterMakerNL
Copy link
Contributor Author

MisterMakerNL commented May 13, 2024

The idea here is also to work from this as a base.
Also move no-stylesheet to dev features.
These 2 styles and the OS-style. I see as the 3 options, in Windows you would have only 2 styles.
If you pick OS-style it would just pick dark or light based on your windows theme.
I think this is how most programs work.

Then OpenThemes and Prodark and Behave-dark, pre-installed as an addon. (as long as they are actively maintained.)
I do not plan to maintain darker/dark/dark modern and such. It's too much work for what it's worth in my opinion. So I'd suggest to remove them unless someone wants to maintain them.
I have a backup as an addon, which will have the latest version as was included in Freecad.

I am btw totally open for improvements like changing the gradient. But I rather do this in separate PR's as this might going to take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants