Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problem] Some stylesheets are not coherent in code and look and are outdated. #11984

Open
2 tasks done
MisterMakerNL opened this issue Jan 14, 2024 · 10 comments
Open
2 tasks done
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Feature FR for improvements or new features Stylesheets Anything regarding stylesheets/themes

Comments

@MisterMakerNL
Copy link
Contributor

MisterMakerNL commented Jan 14, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

Freecad now has

  1. "Dark"
  2. "Darker"
  3. "Dark modern"
  4. "Dark behave"
  5. "Dark contrast"
  6. "ProDark"
  7. "Light"
  8. "Light modern"

8 Stylesheets, but 3 of them are the same and only have different colors.
2 of the 8 are slightly different from the 3, these are the modern version. Those are there to try and make a more modern style. But they have the same code only the tabs and buttons style are different.
Basically the 5 are similar.
Then we have the 3 others:
Which are:

  1. "Dark behave"
  2. "Dark contrast"
  3. "ProDark"
    They all have different code style and look very different.
    They are also not up-to-date the custom color setting and the overlay system have not been checked and there are very minor bugs around.
    Example tiny bugs:
    These buttons in Prodark
    image
    No highlight in the pull-down:
    image
    Overlay in Dark behave same with contrast.
    image
    All the overlay icons aren't good too.
    So not really unusable but also not great.

Full version info

NA

Subproject(s) affected?

None

Anything else?

#11982

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Roy-043 Roy-043 changed the title [Problem] Stylesheets are not coherent in code and looks and are outdated. [Problem] Some stylesheets are not coherent in code and look and are outdated. Jan 14, 2024
@Roy-043 Roy-043 added Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Stylesheets Anything regarding stylesheets/themes labels Jan 14, 2024
@RohanMishra315
Copy link
Contributor

Hey @Roy-043 @MisterMakerNL I would love to look into this ?

@Syres916
Copy link
Contributor

See #12039

@chennes
Copy link
Member

chennes commented Jan 20, 2024

I'm sure all of the stylesheets have some bugs in them, and just like every other piece of code, there are parts that are more actively maintained than others. Let's be careful to separate technical problems (text cut off, buttons the wrong size, etc.) with aesthetic considerations (e.g. "looks outdated"). We don't blindly remove sections of code that no one is working on unless there is a good reason for it, so a discussion about winnowing the number of themes provided by default is its own Issue and should be discussed separately of technical or aesthetic considerations of the themes themselves.

@MisterMakerNL
Copy link
Contributor Author

@chennes It's not about personal choice on looks. More about providing a more polished/uniformly look and keeping it like that over time.
It's also not to withheld options, they definitely should be placed in the addon browser if people are using them.
I just hope there will be someone to maintain them then.

I said it was outdated in looks because of the missing overlay stylesheets mostly.

I do think I should undo behave dark since someone stepped up to maintain it.

@MisterMakerNL
Copy link
Contributor Author

MisterMakerNL commented Feb 2, 2024

I been thinking about this. My actual plan is to make 3 stylesheets.

  1. Will be the most basic version for linux. This is going to be just a stylesheet without any visual additions except some UI fixes, like the custom selection color. It will still follow the Linux stylesheet, so you hardly will see any difference between how it now is.
  2. Will be the same but for windows, although I want to remove the windows specific task window stuff, it should look exactly like how it looks in Linux. If you are using light mode in Linux.
  3. Will be nr 2 but dark.

This would solve the uniformity between Linux and windows.
It would also make it possible to slowly modernize the look, ease users into changes instead of just doing everything.
I hope mac can use these stylesheets too.
I hope we can detect if windows users are using dark style in windows, then we should just automatically switch to dark.
Linux should just be the new default.

Edit-----
There is an issue, if a function like hoover on some element isn't being used right now, it will turn empty
Example if you hoover over an radial button you get this:
image
Default has no hoover.
So it is missing info here.
For Linux this could be an issue since if I add it in the stylesheet it won't use the OS style anymore.
So my solution now will be to not add functions.

@maxwxyz maxwxyz added the Feature FR for improvements or new features label Apr 15, 2024
@maxwxyz
Copy link
Collaborator

maxwxyz commented Apr 15, 2024

To add from the FreeCAD Day 2024 Complaint Session:
When you change the theme it should change everything in contrast with that theme. If you use a light theme then you need to change other colours to make it work.
Discussion:
When using a light theme, in the sketcher I always have to change, for example, the line color because it’s white, it’s not visible. So it would be nice to have a like a style-aware theme, if you change it, change it to something light, it is actually visible, so you don’t have to mess around with additional color settings.
When you change the theme it should also change everything that should be in contrast with that theme to actually be in contrast and legible.
Also when I just changing the background (for example to white) the rest everything is fine and then nothing else is visible.
If you use a light theme then you need to change the color of many things to make it work.

@MisterMakerNL
Copy link
Contributor Author

I hope we fix the line color issue being hardcoded into the Freecad file with the new Material overhaul!!! Since I think the sketch line color was similar to adding a part color.

@furgo16
Copy link
Contributor

furgo16 commented May 11, 2024

Given the direction the Start page is already taking (choice of 3 themes: Classic, Dark, Light), and given that the 1.0 release is shaping up, what are the blockers in this discussion?

image

@MisterMakerNL
Copy link
Contributor Author

I made a dark style that is the same as the no-stylesheet light-style:
#13772
This way we can have 3 settings:
Auto (follow system)/dark/light

@Reqrefusion
Copy link
Contributor

Reqrefusion commented Jun 7, 2024

I am one of those who think this problem should be solved. The steps should be like this:

  • Themes that are not actively maintained should definitely be removed. This seems like the thing to do anyway.

  • For the themes being maintained, only one of them should have dark and light in their names. I think this solves most of the confusion. And it would be good to change bad names too. For example:
    Dark Behave-Blue Night @Syres916
    It is a much more elegant and beautiful-sounding name. Of course, this is just a suggestion, better names can be found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Feature FR for improvements or new features Stylesheets Anything regarding stylesheets/themes
Projects
Development

No branches or pull requests

8 participants