fix: [Translation Migration] Fix split or incomplete translations in reportActionsView #75129

TaduJR · 2025-11-14T08:58:59Z

Explanation of Change

This PR fixes split or incomplete translations in reportActionsView.beginningOfChatHistory by migrating from string concatenation to a parameterized translation approach with HTML rendering.

Problem:
The current implementation uses an incomplete translation string "This chat is with " (with trailing space) and manually assembles the UI by mapping over participants to create individual UserDetailsTooltip components.
This violates translation best practices because:

The translation is split into parts (phrase + names)
Grammar rules (commas, "and") are hardcoded in components instead of translations
Different languages have different grammar rules that can't be expressed

Solution:
Following the established pattern from MentionUserRenderer

Fixed Issues

$ #72050
PROPOSAL: #72050 (comment)

Tests

Test Case 1: One Participant Chat

Open a group chat with exactly 1 participant
Scroll to the beginning of chat history
Verify the welcome message shows: "This chat is with [Name1]."
Hover over each name and verify tooltips appear (In Desktop Versions)
Click each name and verify navigation to respective profiles

Test Case 2: Two Participant Chat

Open a group chat with exactly 2 other participants
Scroll to the beginning of chat history
Verify the welcome message shows: "This chat is with [Name1] and [Name2]."
Verify no comma before "and" for 2 participants
Hover over each name and verify tooltips appear (In Desktop Versions)
Click each name and verify navigation to respective profiles

Test Case 3: Three+ Participant Chat (Group Chat)

Open a group chat with 3+ participants
Scroll to the beginning of chat history
Verify the welcome message shows: "This chat is with [Name1], [Name2], and [Name3]."
Verify commas appear after each name except the last
Verify "and" appears before the final name
Hover over each name and verify tooltips appear (In Desktop Versions)
Click each name and verify navigation to respective profiles

Test Case 4: Optimistic Accounts (Unregistered Users)

Send a money request to an unregistered email/phone number
Open the resulting chat
Scroll to the beginning of chat history
Verify the welcome message displays the unregistered contact's display name
Verify the name is bold, and clickable
Verify hovering shows the tooltip but clicking does nothing

Test Case 5: Concierge & Self-DM

Open Concierge chat
Verify the appropriate welcome message (not affected by this PR)
Open self-DM chat
Verify the appropriate welcome message (not affected by this PR)

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android-Native.mp4

Android: mWeb Chrome

Android-mWeb.mp4

iOS: Native

iOS-Native.mp4

iOS: mWeb Safari

iOS-Safari.mp4

MacOS: Chrome / Safari

Mac-Chrome-1.mp4

MacOS: Desktop

Mac-Desktop.1.mp4

melvin-bot · 2025-11-14T08:59:05Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2025-11-14T08:59:06Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-11-14T09:10:42Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ents/HTMLEngineProvider/BaseHTMLEngineProvider.tsx	`88.67% <100.00%> (+0.21%)`	⬆️
...mponents/HTMLEngineProvider/HTMLRenderers/index.ts	`100.00% <ø> (ø)`
src/components/ReportWelcomeText.tsx	`88.13% <100.00%> (+2.02%)`	⬆️
src/libs/SidebarUtils.ts	`81.83% <95.00%> (+0.84%)`	⬆️
...gineProvider/HTMLRenderers/UserDetailsRenderer.tsx	`77.77% <77.77%> (ø)`
... and 196 files with indirect coverage changes

…reportActionsView

situchan · 2025-11-15T19:13:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

situchan

@TaduJR Screenshots are missing on all platforms

src/components/ReportWelcomeText.tsx

…t-or-incomplete-translations-in-reportActionsView

…nslations-in-reportActionsView

…t-or-incomplete-translations-in-reportActionsView

…tion-Migration-Fix-split-or-incomplete-translations-in-reportActionsView

…t-or-incomplete-translations-in-reportActionsView

…lations-in-reportActionsView' of https://github.com/TaduJR/App into fix-Translation-Migration-Fix-split-or-incomplete-translations-in-reportActionsView

TaduJR · 2025-11-22T10:33:34Z

@TaduJR Screenshots are missing on all platforms

All Done @situchan

…tion-Migration-Fix-split-or-incomplete-translations-in-reportActionsView

…t-or-incomplete-translations-in-reportActionsView

situchan

getWelcomeMessage function is also used to show alternative text in LHN.
There's regression.

Expected:

Actual:

…t-or-incomplete-translations-in-reportActionsView

TaduJR · 2025-11-29T09:34:47Z

Oh Thanks @situchan

Done.

situchan · 2025-11-30T17:17:36Z

src/libs/SidebarUtils.ts

+    }
+
+    welcomeMessage.messageHtml = messageHtml;
+    welcomeMessage.messageText = Parser.htmlToText(welcomeMessage.messageHtml);


How can we make sure that messageText is exactly the same as before migration?

App/src/libs/SidebarUtils.ts

Line 1079 in f82a8db

welcomeMessage.messageText = displayNamesWithTooltips.length ? ensureSingleSpacing(`${welcomeMessage.phrase1} ${displayNamesWithTooltipsText}`) : '';

ensureSingleSpacing is no longer needed?

Can we add some unit tests to confirm no regression in messageText?

There should be no difference between Parser.htmlToText(welcomeMessage.messageHtml) and

displayNamesWithTooltips.length ? ensureSingleSpacing(`${welcomeMessage.phrase1} ${displayNamesWithTooltipsText}`) : ''

situchan · 2025-11-30T18:00:13Z

Test Case 4: 5. Verify the name is bold but NOT clickable

I think test step is wrong. It's clickable

Screen.Recording.2025-11-30.at.11.58.35.PM.mov

TaduJR · 2025-12-01T02:22:26Z

Can we add some unit tests to confirm no regression in messageText?

Done.

situchan · 2025-12-01T02:54:06Z

Job 8 is failing but I think it's expected as it's now 12/25.
We should fix this in a separate issue, not related to this PR.

TaduJR requested review from a team as code owners November 14, 2025 08:59

melvin-bot bot assigned TaduJR Nov 14, 2025

melvin-bot bot requested review from JmillsExpensify and situchan November 14, 2025 08:59

melvin-bot bot removed request for a team and JmillsExpensify November 14, 2025 08:59

fix: [Translation Migration] Fix split or incomplete translations in …

685df71

…reportActionsView

TaduJR force-pushed the fix-Translation-Migration-Fix-split-or-incomplete-translations-in-reportActionsView branch from aa3534e to 685df71 Compare November 14, 2025 09:58

fix: eslint error

15caba1

situchan suggested changes Nov 15, 2025

View reviewed changes

situchan reviewed Nov 16, 2025

View reviewed changes

src/components/ReportWelcomeText.tsx Outdated Show resolved Hide resolved

Merge branch 'Expensify:main' into fix-Translation-Migration-Fix-spli…

593133f

…t-or-incomplete-translations-in-reportActionsView

trjExpensify mentioned this pull request Nov 17, 2025

[Hold #72050][Translations] Update the prompt to not remove spaces at the end of sentences. #64350

Open

16 tasks

TaduJR added 2 commits November 18, 2025 11:00

Merge main into fix-Translation-Migration-Fix-split-or-incomplete-tra…

ca34574

…nslations-in-reportActionsView

chore: move additional text generation to SidebarUtils for cleaner code

3f45aa2

TaduJR requested a review from situchan November 18, 2025 08:24

TaduJR added 3 commits November 18, 2025 14:45

Merge branch 'Expensify:main' into fix-Translation-Migration-Fix-spli…

538e574

…t-or-incomplete-translations-in-reportActionsView

Merge branch 'Expensify:main' into fix-Translation-Migration-Fix-spli…

1501dde

…t-or-incomplete-translations-in-reportActionsView

Merge branch 'Expensify:main' into fix-Translation-Migration-Fix-spli…

6237469

…t-or-incomplete-translations-in-reportActionsView

TaduJR closed this Nov 20, 2025

TaduJR deleted the fix-Translation-Migration-Fix-split-or-incomplete-translations-in-reportActionsView branch November 20, 2025 06:34

TaduJR restored the fix-Translation-Migration-Fix-split-or-incomplete-translations-in-reportActionsView branch November 20, 2025 06:34

Merge branch 'Expensify:main' into fix-Translation-Migration-Fix-spli…

af73561

…t-or-incomplete-translations-in-reportActionsView

TaduJR reopened this Nov 20, 2025

TaduJR and others added 3 commits November 22, 2025 00:35

Merge branch 'main' of https://github.com/TaduJR/App into fix-Transla…

1a7bcd9

…tion-Migration-Fix-split-or-incomplete-translations-in-reportActionsView

Merge branch 'Expensify:main' into fix-Translation-Migration-Fix-spli…

dd71cb3

…t-or-incomplete-translations-in-reportActionsView

Merge branch 'fix-Translation-Migration-Fix-split-or-incomplete-trans…

96cf616

…lations-in-reportActionsView' of https://github.com/TaduJR/App into fix-Translation-Migration-Fix-split-or-incomplete-translations-in-reportActionsView

TaduJR and others added 3 commits November 24, 2025 18:33

Merge branch 'main' of https://github.com/TaduJR/App into fix-Transla…

25caba9

…tion-Migration-Fix-split-or-incomplete-translations-in-reportActionsView

Merge branch 'Expensify:main' into fix-Translation-Migration-Fix-spli…

c6d87f2

…t-or-incomplete-translations-in-reportActionsView

Merge branch 'Expensify:main' into fix-Translation-Migration-Fix-spli…

f563af1

…t-or-incomplete-translations-in-reportActionsView

situchan suggested changes Nov 28, 2025

View reviewed changes

TaduJR and others added 2 commits November 29, 2025 12:25

Merge branch 'Expensify:main' into fix-Translation-Migration-Fix-spli…

3a6b053

…t-or-incomplete-translations-in-reportActionsView

fix: LHN regression by setting messageText from messageHtml

0bcd546

TaduJR requested a review from situchan November 29, 2025 09:34

situchan reviewed Nov 30, 2025

View reviewed changes

fix: LHN regression by setting messageText from messageHtml

d01ce59

situchan approved these changes Dec 1, 2025

View reviewed changes

melvin-bot bot requested a review from roryabraham December 1, 2025 02:54

fix: [Translation Migration] Fix split or incomplete translations in reportActionsView #75129

Are you sure you want to change the base?

fix: [Translation Migration] Fix split or incomplete translations in reportActionsView #75129

Conversation

TaduJR commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 14, 2025

Uh oh!

melvin-bot bot commented Nov 14, 2025

Uh oh!

codecov bot commented Nov 14, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

situchan commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TaduJR commented Nov 22, 2025

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

TaduJR commented Nov 29, 2025

Uh oh!

situchan Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

situchan commented Nov 30, 2025

Uh oh!

TaduJR commented Dec 1, 2025

Uh oh!

situchan commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TaduJR commented Nov 14, 2025 •

edited

Loading

codecov bot commented Nov 14, 2025 •

edited by github-actions bot

Loading

situchan commented Nov 15, 2025 •

edited

Loading

situchan commented Dec 1, 2025 •

edited

Loading