Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multiline plot for translation #62

Conversation

RekhaAngara
Copy link
Contributor

@RekhaAngara RekhaAngara commented Aug 5, 2021

#61

Adding a PR with the solution @veghp suggested

@RekhaAngara RekhaAngara force-pushed the update_multiline_plot_for_translation branch from 4344269 to 5efcd7e Compare August 6, 2021 00:04
@veghp
Copy link
Member

veghp commented Sep 20, 2021

Thank you, yes this is the solution I had. There is one more thing to sort out before we merge: in some cases, a few letters are also translated on the line after the last line. See example:

test_translation.pdf

This is not related to the PDF conversion, or the crop method. I'll try and look into it, I think it will involve handling line_virtual_end properly.

@veghp veghp merged commit 5efcd7e into Edinburgh-Genome-Foundry:master Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants