[DMS-26] Generate dependencies #193
Conversation
| if (resourceName == "EducationOrganization") | ||
| { | ||
| resourceName = "School"; | ||
| } |
There was a problem hiding this comment.
Open to suggestions here. Definitely a code smell.
There was a problem hiding this comment.
Here's an idea. Read the abtractResources section to get EducationOrganization and GeneralStudentProgramAssociation. Then scan the resources for the first one that has isSubclass: true and matches each. Use that instead.
It might work, or it might be too simplistic in that it picks e.g. EducationOrganizationNetwork which isn't as "connected" (from a dependency graph perspective) as School. In which case you'd need to do some sort of "connectedness" analysis of subclasses to select the one to substitute.
There was a problem hiding this comment.
Another idea, ignore the abstract superclasses to start and get an ordering. Then find all the subclasses in the ordering and insert the superclass right after the last subclass. That's probably the easiest way.
src/frontend/EdFi.DataManagementService.Frontend.AspNetCore/Modules/MetadataEndpointModule.cs
Outdated
Show resolved
Hide resolved
simpat-adam
force-pushed
the
DMS-26
branch
6 times, most recently
from
e32144e to
7602b58
Compare
simpat-adam
force-pushed
the
DMS-26
branch
2 times, most recently
from
3cf5c75 to
f673452
Compare
simpat-adam
force-pushed
the
DMS-26
branch
2 times, most recently
from
867d22b to
3f5ddbb
Compare
simpat-adam
force-pushed
the
DMS-26
branch
2 times, most recently
from
902c366 to
0ec5ea5
Compare
| } | ||
| """; | ||
|
|
||
| private readonly string _expectedDescriptor = |
There was a problem hiding this comment.
_expectedDependencies?
| } | ||
|
|
||
| [TestFixture] | ||
| public class Given_A_Dependency_Calculator() : DependencyCalculatorTests |
| } | ||
| """; | ||
|
|
||
| private readonly string _expectedDescriptor = |
There was a problem hiding this comment.
_expectedDependencies?
No description provided.