Extract Dependency calculation to dedicated class

Ed-Fi-Alliance-OSS · Jul 18, 2024 · 7d8b1b4 · 7d8b1b4
1 parent faede87
commit 7d8b1b4
Show file tree

Hide file tree

Showing 2 changed files with 95 additions and 77 deletions.
diff --git a/src/core/EdFi.DataManagementService.Core/ApiSchema/DependencyCalculator.cs b/src/core/EdFi.DataManagementService.Core/ApiSchema/DependencyCalculator.cs
@@ -0,0 +1,93 @@
+// SPDX-License-Identifier: Apache-2.0
+// Licensed to the Ed-Fi Alliance under one or more agreements.
+// The Ed-Fi Alliance licenses this file to you under the Apache License, Version 2.0.
+// See the LICENSE and NOTICES files in the project root for more information.
+
+using System.Text.Json.Nodes;
+using Microsoft.Extensions.Logging;
+
+namespace EdFi.DataManagementService.Core.ApiSchema;
+
+internal class DependencyCalculator(JsonNode _apiSchemaRootNode, ILogger _logger)
+{
+    public JsonArray GetDependencies()
+    {
+        var apiSchemaDocument = new ApiSchemaDocument(_apiSchemaRootNode, _logger);
+        var dependenciesJsonArray = new JsonArray();
+        foreach (JsonNode projectSchemaNode in apiSchemaDocument.GetAllProjectSchemaNodes())
+        {
+            var resourceSchemas = projectSchemaNode["resourceSchemas"]?.AsObject().Select(x => new ResourceSchema(x.Value!)).ToList()!;
+
+            Dictionary<string, List<string>> dependencies =
+                resourceSchemas.ToDictionary(rs => rs.ResourceName.Value, rs => new List<string>());
+
+            foreach (var resourceSchema in resourceSchemas)
+            {
+                foreach (var documentPath in resourceSchema.DocumentPaths.Where(d => d.IsReference))
+                {
+                    dependencies[resourceSchema.ResourceName.Value].Add(documentPath.ResourceName.Value);
+                }
+            }
+
+            List<KeyValuePair<string, int>> orderedResources = [];
+            Dictionary<string, int> visitedResources = [];
+            foreach (var dependency in dependencies.OrderBy(d => d.Value.Count).ThenBy(d => d.Key).Select(d => d.Key))
+            {
+                RecursivelyDetermineDependencies(dependency, 0);
+            }
+
+            foreach (var orderedResource in orderedResources.OrderBy(o => o.Value).ThenBy(o => o.Key))
+            {
+                dependenciesJsonArray.Add(new { resource = $"/{projectSchemaNode!.GetPropertyName()}/{orderedResource.Key.First().ToString().ToLowerInvariant()}{orderedResource.Key.Substring(1)}", order = orderedResource.Value, operations = new[] { "Create", "Update" } });
+            }
+
+            int RecursivelyDetermineDependencies(string resourceName, int depth)
+            {
+                // Code Smell here:
+                // These resources are similar to abstract base classes, so they are not represented in the resourceSchemas
+                // portion of the schema document. This is a rudimentary replacement with the most specific version of the resource
+                if (resourceName == "EducationOrganization")
+                {
+                    resourceName = "School";
+                }
+
+                if (resourceName == "GeneralStudentProgramAssociation")
+                {
+                    resourceName = "StudentProgramAssociation";
+                }
+
+                if (!visitedResources.ContainsKey(resourceName))
+                {
+                    visitedResources.Add(resourceName, 0);
+                }
+
+                var maxDepth = depth;
+                if (dependencies.ContainsKey(resourceName))
+                {
+                    foreach (var dependency in dependencies[resourceName])
+                    {
+                        if (visitedResources.ContainsKey(dependency))
+                        {
+                            if (visitedResources[dependency] > maxDepth)
+                            {
+                                maxDepth = visitedResources[dependency];
+                            }
+                        }
+                        else
+                        {
+                            var level = RecursivelyDetermineDependencies(dependency, depth);
+                            if (level > maxDepth)
+                                maxDepth = level;
+                        }
+                    }
+                    orderedResources.Add(new KeyValuePair<string, int>(resourceName, maxDepth + 1));
+                    visitedResources[resourceName] = maxDepth + 1;
+                }
+
+                return maxDepth + 1;
+            }
+        }
+
+        return dependenciesJsonArray;
+    }
+}
diff --git a/src/core/EdFi.DataManagementService.Core/ApiService.cs b/src/core/EdFi.DataManagementService.Core/ApiService.cs
@@ -258,82 +258,7 @@ public IList<IDataModelInfo> GetDataModelInfo()
     /// <returns>JSON array ordered by dependency sequence</returns>
     public JsonArray GetDependencies()
     {
-        var apiSchemaDocument = new ApiSchemaDocument(_apiSchemaProvider.ApiSchemaRootNode, _logger);
-        var dependenciesJsonArray = new JsonArray();
-        foreach (JsonNode projectSchemaNode in apiSchemaDocument.GetAllProjectSchemaNodes())
-        {
-            var resourceSchemas = projectSchemaNode["resourceSchemas"]?.AsObject().Select(x => new ResourceSchema(x.Value!)).ToList()!;
-
-            Dictionary<string, List<string>> dependencies =
-                resourceSchemas.ToDictionary(rs => rs.ResourceName.Value, rs => new List<string>());
-
-            foreach (var resourceSchema in resourceSchemas)
-            {
-                foreach (var documentPath in resourceSchema.DocumentPaths.Where(d => d.IsReference))
-                {
-                    dependencies[resourceSchema.ResourceName.Value].Add(documentPath.ResourceName.Value);
-                }
-            }
-
-            List<KeyValuePair<string, int>> orderedResources = [];
-            Dictionary<string, int> visitedResources = [];
-            foreach (var dependency in dependencies.OrderBy(d => d.Value.Count).ThenBy(d => d.Key).Select(d => d.Key))
-            {
-                RecursivelyDetermineDependencies(dependency, 0);
-            }
-
-            foreach (var orderedResource in orderedResources.OrderBy(o => o.Value).ThenBy(o => o.Key))
-            {
-                dependenciesJsonArray.Add(new { resource = $"/{projectSchemaNode!.GetPropertyName()}/{orderedResource.Key.First().ToString().ToLowerInvariant()}{orderedResource.Key.Substring(1)}", order = orderedResource.Value, operations = new[] { "Create", "Update" } });
-            }
-
-            int RecursivelyDetermineDependencies(string resourceName, int depth)
-            {
-                // Code Smell here:
-                // These resources are similar to abstract base classes, so they are not represented in the resourceSchemas
-                // portion of the schema document. This is a rudimentary replacement with the most specific version of the resource
-                if (resourceName == "EducationOrganization")
-                {
-                    resourceName = "School";
-                }
-
-                if (resourceName == "GeneralStudentProgramAssociation")
-                {
-                    resourceName = "StudentProgramAssociation";
-                }
-
-                if (!visitedResources.ContainsKey(resourceName))
-                {
-                    visitedResources.Add(resourceName, 0);
-                }
-
-                var maxDepth = depth;
-                if (dependencies.ContainsKey(resourceName))
-                {
-                    foreach (var dependency in dependencies[resourceName])
-                    {
-                        if (visitedResources.ContainsKey(dependency))
-                        {
-                            if (visitedResources[dependency] > maxDepth)
-                            {
-                                maxDepth = visitedResources[dependency];
-                            }
-                        }
-                        else
-                        {
-                            var level = RecursivelyDetermineDependencies(dependency, depth);
-                            if (level > maxDepth)
-                                maxDepth = level;
-                        }
-                    }
-                    orderedResources.Add(new KeyValuePair<string, int>(resourceName, maxDepth + 1));
-                    visitedResources[resourceName] = maxDepth + 1;
-                }
-
-                return maxDepth + 1;
-            }
-        }
-
-        return dependenciesJsonArray;
+        var dependencyCalculator = new DependencyCalculator(_apiSchemaProvider.ApiSchemaRootNode, _logger);
+        return dependencyCalculator.GetDependencies();
     }
 }