feat: funman parameter graph interactions #5163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
shawnyama
requested review from
YohannParis,
mwdchang,
jryu01,
Tom-Szendrey,
blanchco and
asylves1
as code owners
shawnyama
changed the title
YohannParis
approved these changes
Oct 17, 2024
mwdchang
reviewed
Oct 17, 2024
| <vega-chart | ||
| :visualization-spec="parameterCharts" | ||
| :are-embed-actions-visible="false" | ||
| @chart-click="onParameterChartClick" |
There was a problem hiding this comment.
Can you explain a bit how the visual encodings work with respect to click on the parameters' rug plot? I played around with it and it is confusing what had been selected.
mwdchang
requested changes
Oct 17, 2024
There was a problem hiding this comment.
Probably not directly related to this PR, but since you are working in the area: There is something strange with how you are collecting the trajectories for funman results. Notice below you have several markers on the same x-axis (eg at 80 and 90) - this means it is no longer a function of time and is therefore incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I set up the logic for highlighting a specific line in the state graph that would use aboxId. However getting theboxIdI want from the parameter graph is what I am missing. So that needs to be handled later. I am stuck on emitting theboxIdout of the parameter graph, I posted a stackoverflow question to a vega-lite slack channel (since that's how they wanted it): https://stackoverflow.com/questions/79094839/trying-to-get-scoped-param-value-out-of-vega-lite-specchart-clickemit to pass the parameter chart'sboxIdto highlight the state chart's corresponding line.Screen.Recording.2024-10-17.at.1.58.46.PM.mov