Skip to content

EP-2612 - [Partial changes] Update cart header and empty cart message for clarity #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zweatshirt wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

EP-2612 - [Partial changes] Update cart header and empty cart message for clarity #1253

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3011385
Update cart header and empty cart message for clarity
zweatshirt Nov 5, 2025
310f046
Update terminology from "cart" to "gifts" for consistency across the …
zweatshirt Nov 5, 2025
949346f
Fix typos in gift-related messages for improved clarity
zweatshirt Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/app/cart/cart.tpl.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<div class="row">
<div class="col-sm-6">
<h3 id="cart-header" class="panel-name" translate>
Your Gift Cart
Selected Gifts
</h3>
</div>
<div class="col-sm-6 text-right">
Expand All @@ -18,19 +18,19 @@ <h3 id="cart-header" class="panel-name" translate>
class="text-right"
ng-if="$ctrl.updating"
>
<translate>Updating cart...</translate>
<translate>Updating gifts...</translate>
</loading>
</div>
</div>
<div class="alert alert-danger" role="alert" ng-if="$ctrl.error">
<p ng-if="$ctrl.error.loading" translate>
Error loading your cart.
Error loading your gifts.
<a id="retryLoadButton" href="" ng-click="$ctrl.loadCart()"
>Retry</a
>
</p>
<p ng-if="$ctrl.error.updating" translate>
Error loading your updated cart.
Error loading your updated gifts.
<a
id="retryUpdateButton"
href=""
Expand All @@ -46,7 +46,7 @@ <h3 id="cart-header" class="panel-name" translate>
ng-if="$ctrl.cartData && !$ctrl.cartData.items.length"
translate
>
Your cart is empty
You have no gifts selected
</p>
<form ng-if="$ctrl.cartData.items.length">
<table
Expand Down Expand Up @@ -167,7 +167,7 @@ <h3 id="cart-header" class="panel-name" translate>
class="mb-- text-right"
ng-if="$ctrl.updating"
>
<translate>Updating cart...</translate>
<translate>Updating gifts...</translate>
</loading>
<div class="checkout-cart-summary pull-left">
<display-rate-totals
Expand Down
4 changes: 2 additions & 2 deletions src/app/checkout/cart-summary/cart-summary.tpl.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="panel loading-overlay-parent">
<div class="panel-body">
<h3 id="cart-summary-header" class="panel-name" translate>Cart Summary</h3>
<h3 id="cart-summary-header" class="panel-name" translate>Gifts Summary</h3>
<table
class="table giftsum-table giftsum-table-cart"
aria-labelledby="cart-summary-header"
Expand Down Expand Up @@ -39,7 +39,7 @@ <h3 id="cart-summary-header" class="panel-name" translate>Cart Summary</h3>
ng-href="{{$ctrl.buildCartUrl()}}"
class="btn btn-subtle mt"
translate
>Edit Cart</a
>Edit Gifts</a
>
<recaptcha-wrapper
ng-if="$ctrl.showSubmitBtn"
Expand Down
6 changes: 3 additions & 3 deletions src/app/checkout/checkout.tpl.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,21 @@
<div class="panel">
<div class="panel-body">
<loading ng-if="$ctrl.loadingCartData">
<translate>Loading cart data...</translate>
<translate>Loading gift data...</translate>
</loading>
<div
class="alert alert-warning"
role="alert"
ng-if="$ctrl.cartData && !$ctrl.cartData.items.length"
>
<p translate>Your cart is empty</p>
<p translate>Your have no selected gifts</p>
Copy link

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical error: 'Your have' should be 'You have'.

Suggested change
<p translate>Your have no selected gifts</p>
<p translate>You have no selected gifts</p>

Copilot uses AI. Check for mistakes.
</div>
<div
class="alert alert-danger"
role="alert"
ng-if="!$ctrl.loadingCartData && !$ctrl.cartData"
>
<p translate>There was an error loading your cart</p>
<p translate>There was an error loading your gifts</p>
</div>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions src/app/checkout/step-1/step-1.tpl.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
ng-href="{{$ctrl.buildCartUrl()}}"
class="btn btn-default"
translate
>Return to Cart</a
>Return to Selected Gifts</a
>
</div>
<div class="col-sm-5 col-sm-offset-2">
Expand All @@ -30,7 +30,7 @@
class="btn btn-link btn-block visible-xs"
>
<i class="fa fa-angle-left"></i>
<translate>Return to Cart</translate>
<translate>Return to Selected Gifts</translate>
</a>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/app/main/main.tpl.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<ul class="list-inline container">
<li><a href="/search-results.html">Search</a></li>
<li><a href="/cart.html">Cart</a></li>
<li><a href="/cart.html">Gifts</a></li>
<li><a href="/sign-in.html">Sign-In</a></li>
<li><a href="/checkout.html">Checkout</a></li>
<li><a href="/thank-you.html">Thank You</a></li>
Expand Down
4 changes: 2 additions & 2 deletions src/app/productConfig/productConfigModal/productConfig.modal.tpl.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
ng-click="$ctrl.close(); $ctrl.$window.location = $ctrl.buildCartUrl()"
translate
>
View Cart
View Selected Gifts
</button>
<button
class="btn btn-md btn-primary btn-block-xs pull-right"
Expand All @@ -52,7 +52,7 @@
ng-disabled="$ctrl.state === 'changingFrequency' || $ctrl.state === 'submitting' || $ctrl.state === 'errorLoading'"
>
<span ng-switch-when="true" translate>Update Gift</span>
<span ng-switch-when="false" translate>Add to Gift Cart</span>
<span ng-switch-when="false" translate>Add to Gifts</span>
</button>
</div>
</div>
10 changes: 5 additions & 5 deletions src/app/profile/yourGiving/giveOneTimeGift/step2/enterAmounts.tpl.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ <h3 translate>Give an Extra One-Time Gift</h3>
ng-if="$ctrl.errors.addToCart"
>
<p translate>
There was an error adding some of your gifts to cart. The ones below
were unable to be added to cart.
There was an error adding some of your gifts. The ones below were
unable to be added to your gifts.
Copy link

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message 'unable to be added to your gifts' is unclear. Consider using 'unable to be added' or 'could not be selected' to avoid the awkward 'added to your gifts' phrasing.

Suggested change
There was an error adding some of your gifts. The ones below were
unable to be added to your gifts.
There was an error adding some of your gifts. The ones below could not be added.

Copilot uses AI. Check for mistakes.
</p>
</div>
<div
Expand Down Expand Up @@ -68,13 +68,13 @@ <h3 translate>Give an Extra One-Time Gift</h3>
ng-click="$ctrl.addToCart()"
ng-disabled="!$ctrl.hasSelectedRecipients || $ctrl.addingToCart"
>
<span ng-if="$ctrl.addingToCart" translate>Adding to Cart...</span>
<span ng-if="!$ctrl.addingToCart" translate>Add to Cart</span>
<span ng-if="$ctrl.addingToCart" translate>Adding to Gifts...</span>
<span ng-if="!$ctrl.addingToCart" translate>Add to Gifts</span>
<span
class="sr-only"
aria-live="polite"
aria-atomic="true"
ng-bind="$ctrl.addingToCart ? ('Adding to Cart...' | translate) : ''"
ng-bind="$ctrl.addingToCart ? ('Adding to Gifts...' | translate) : ''"
>
</span>
</button>
Expand Down
4 changes: 2 additions & 2 deletions src/common/components/failedVerificationModal/failedVerificationModal.tpl.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
or email <a href="mailto:[email protected]">[email protected]</a>.
</p>
<p>
We apologize for the inconvenience. You may still finish giving the gifts in
your cart by checking out as a guest.
We apologize for the inconvenience. You may still finish giving your gifts
by checking out as a guest.
</p>
</div>
4 changes: 2 additions & 2 deletions src/common/components/nav/navCart/navCart.tpl.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@
ng-if="!$ctrl.hasItems && !$ctrl.loading && !$ctrl.error"
>
<div class="col-xs-12">
<p class="text-center mt-" translate>Your cart is empty</p>
<p class="text-center mt-" translate>Your have no gifts selected</p>
Copy link

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical error: 'Your have' should be 'You have'.

Suggested change
<p class="text-center mt-" translate>Your have no gifts selected</p>
<p class="text-center mt-" translate>You have no gifts selected</p>

Copilot uses AI. Check for mistakes.
</div>
</div>

<div class="row repeating-row" ng-if="$ctrl.error">
<div class="col-xs-12 text-center mt- text-warning">
<p translate>
There was an error loading your cart.
There was an error loading your selected gifts.
<br />
You can <a href="" ng-click="$ctrl.loadCart()">try again</a>.
</p>
Expand Down
3 changes: 1 addition & 2 deletions src/common/components/userMatchModal/userMatchModal.tpl.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,7 @@ <h4 class="text-center" translate>Success!</h4>
activated, and you are signed in.
</p>
<p ng-if="$ctrl.cartCount > 0" translate>
You may now resume checkout to continue giving the gifts that are in
your cart.
You may now resume checkout to continue giving your gifts.
</p>
<p ng-if="$ctrl.cartCount === 0" translate>
You may now find giving opportunities or view your dashboard.
Expand Down