-
Notifications
You must be signed in to change notification settings - Fork 1
EP-2612 - [Partial changes] Update cart header and empty cart message for clarity #1253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates user-facing terminology throughout the application, replacing "cart" language with "gifts" or "selected gifts" to better align with the giving/donation context. This improves clarity for users by using domain-specific language that better describes the donation selection process.
Key Changes:
- Replaced "cart" references with "gifts" or "selected gifts" in user-facing messages
- Updated button labels from "Add to Cart" to "Add to Gifts"
- Modified error messages to reference "gifts" instead of "cart"
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| userMatchModal.tpl.html | Simplified success message about resuming checkout |
| navCart.tpl.html | Updated empty state and error messages to use "gifts" terminology |
| failedVerificationModal.tpl.html | Changed error message to reference "gifts" instead of "cart" |
| enterAmounts.tpl.html | Updated button labels and error messages to use "gifts" terminology |
| productConfig.modal.tpl.html | Changed button labels from cart-related to gifts-related |
| main.tpl.html | Updated navigation link text from "Cart" to "Gifts" |
| step-1.tpl.html | Changed "Return to Cart" button to "Return to Selected Gifts" |
| checkout.tpl.html | Updated loading and error messages to reference "gifts" |
| cart-summary.tpl.html | Changed heading and button text to use "gifts" terminology |
| cart.tpl.html | Updated all user-facing text from cart to gifts terminology |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| > | ||
| <div class="col-xs-12"> | ||
| <p class="text-center mt-" translate>Your cart is empty</p> | ||
| <p class="text-center mt-" translate>Your have no gifts selected</p> |
Copilot
AI
Nov 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammatical error: 'Your have' should be 'You have'.
| <p class="text-center mt-" translate>Your have no gifts selected</p> | |
| <p class="text-center mt-" translate>You have no gifts selected</p> |
src/app/checkout/checkout.tpl.html
Outdated
| ng-if="$ctrl.cartData && !$ctrl.cartData.items.length" | ||
| > | ||
| <p translate>Your cart is empty</p> | ||
| <p translate>Your have no selected gifts</p> |
Copilot
AI
Nov 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammatical error: 'Your have' should be 'You have'.
| <p translate>Your have no selected gifts</p> | |
| <p translate>You have no selected gifts</p> |
| There was an error adding some of your gifts. The ones below were | ||
| unable to be added to your gifts. |
Copilot
AI
Nov 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message 'unable to be added to your gifts' is unclear. Consider using 'unable to be added' or 'could not be selected' to avoid the awkward 'added to your gifts' phrasing.
| There was an error adding some of your gifts. The ones below were | |
| unable to be added to your gifts. | |
| There was an error adding some of your gifts. The ones below could not be added. |
Description
Related Jira ticket
TODO:
Testing
Checklist:
stage-branch-mergersuccessfully merged my branch to staging or manually merged it myself