Skip to content

Constraints update (automatic vanishing constraints for inactive misc sub perspectives) #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: arith-dev
Choose a base branch
from
Open

Constraints update (automatic vanishing constraints for inactive misc sub perspectives) #2468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd26ba6
update: contraints commit
OlivierBBB Nov 5, 2025
d648676
fix: reduce gas limit in test for Osaka compatibility
OlivierBBB Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...java/net/consensys/linea/zktracer/instructionprocessing/ContractModifyingStorageTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ void contractModifyingStorageInFunctionTest(TestInfo testInfo) {
Bytes.fromHexString(
"0x608060405234801561001057600080fd5b50610304806100206000396000f3fe608060405234801561001057600080fd5b50600436106100575760003560e01c8063501e82121461005c5780636cc014de1461007a578063a314150f14610098578063a5d666a9146100b6578063e8af2fa5146100d4575b600080fd5b6100646100de565b60405161007191906101ca565b60405180910390f35b6100826100e4565b60405161008f91906101ca565b60405180910390f35b6100a06100ea565b6040516100ad91906101ca565b60405180910390f35b6100be6100f0565b6040516100cb91906101ca565b60405180910390f35b6100dc6100f6565b005b60005481565b60015481565b60025481565b60035481565b60008081905550600180819055506002808190555060038081905550600a60005461012191906101e5565b600081905550600b60015461013691906101e5565b600181905550600c60025461014b91906101e5565b600281905550600d60035461016091906101e5565b60038190555060008054610174919061023b565b6000819055506014600154610189919061023b565b600181905550601560025461019e919061023b565b60028190555060156003546101b3919061023b565b600381905550565b6101c481610295565b82525050565b60006020820190506101df60008301846101bb565b92915050565b60006101f082610295565b91506101fb83610295565b9250827fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff038211156102305761022f61029f565b5b828201905092915050565b600061024682610295565b915061025183610295565b9250817fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff048311821515161561028a5761028961029f565b5b828202905092915050565b6000819050919050565b7f4e487b7100000000000000000000000000000000000000000000000000000000600052601160045260246000fdfea26469706673582212200d443753b26ea215c94e8fd1b03e4d389ebc740d96823003d127316393455da664736f6c63430008000033"))
.transactionType(TransactionType.FRONTIER)
.gasLimit(0x38444C0L)
.gasLimit(16777216L)
.value(Wei.ZERO)
.keyPair(keyPair)
.build();
Expand Down
2 changes: 1 addition & 1 deletion ...t/java/net/consensys/linea/zktracer/module/limits/precompileLimits/ModexpLimitsTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ void modexpCall(int bbs, int ebs, int mbs, TestInfo testInfo) {
.sender(senderAccount)
.to(callPRC)
.keyPair(senderKeyPair)
.gasLimit(30000000L)
.gasLimit(16777216L)
Copy link

@cursor cursor bot Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Gas limit reduction risks MODEXP tests failing you

Gas limit reduced from 30,000,000 to 16,777,216 (44% reduction) may be insufficient for MODEXP precompile calls with large parameters. The test is parameterized with byte sizes up to 513 bytes for base, exponent, and modulus, and MODEXP gas costs scale significantly with input size. This reduction could cause legitimate test cases to fail with out-of-gas errors, potentially masking whether the test failures are due to intended validation logic or insufficient gas.

Fix in Cursor Fix in Web

.value(Wei.of(10000000))
.build();

Expand Down
2 changes: 1 addition & 1 deletion linea-constraints
Open in desktop
Submodule linea-constraints updated 23 files
+17 −5 Makefile
+1 −1 constants/cancun/constants.zkasm
+1 −1 constants/london/constants.zkasm
+3 −0 constants/osaka/constants.zkasm
+1 −1 constants/prague/constants.zkasm
+0 −0 ecdata/london/columns.lisp
+0 −0 ecdata/london/constants.lisp
+0 −0 ecdata/london/constraints.lisp
+0 −0 ecdata/london/lookups/ecdata_into_ext.lisp
+0 −0 ecdata/london/lookups/ecdata_into_wcp.lisp
+76 −0 ecdata/osaka/columns.lisp
+33 −0 ecdata/osaka/constants.lisp
+755 −0 ecdata/osaka/constraints.lisp
+33 −0 ecdata/osaka/lookups/ecdata_into_ext.lisp
+27 −0 ecdata/osaka/lookups/ecdata_into_wcp.lisp
+2 −2 hub/osaka/columns/miscellaneous.lisp
+19 −0 hub/osaka/constraints/miscellaneous-rows/automatic-vanishing/exp.lisp
+32 −0 hub/osaka/constraints/miscellaneous-rows/automatic-vanishing/mmu.lisp
+33 −0 hub/osaka/constraints/miscellaneous-rows/automatic-vanishing/mxp.lisp
+19 −0 hub/osaka/constraints/miscellaneous-rows/automatic-vanishing/oob.lisp
+29 −0 hub/osaka/constraints/miscellaneous-rows/automatic-vanishing/stp.lisp
+5 −2 trm/trm_london.zkasm
+49 −0 trm/trm_osaka.zkasm
Loading