Skip to content

Conversation

@OlivierBBB
Copy link
Collaborator

@OlivierBBB OlivierBBB commented Nov 5, 2025

Note

Normalize test transaction gas limits to 16,777,216 across affected tests.

  • Tests:
    • Align transaction gasLimit to 16777216L in:
      • arithmetization/src/test/java/net/consensys/linea/zktracer/instructionprocessing/ContractModifyingStorageTest.java (from 0x38444C0L).
      • arithmetization/src/test/java/net/consensys/linea/zktracer/module/limits/precompileLimits/ModexpLimitsTests.java (from 30000000L).

Written by Cursor Bugbot for commit d648676. This will update automatically on new commits. Configure here.

.to(callPRC)
.keyPair(senderKeyPair)
.gasLimit(30000000L)
.gasLimit(16777216L)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Gas limit reduction risks MODEXP tests failing you

Gas limit reduced from 30,000,000 to 16,777,216 (44% reduction) may be insufficient for MODEXP precompile calls with large parameters. The test is parameterized with byte sizes up to 513 bytes for base, exponent, and modulus, and MODEXP gas costs scale significantly with input size. This reduction could cause legitimate test cases to fail with out-of-gas errors, potentially masking whether the test failures are due to intended validation logic or insufficient gas.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants