Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser: accessibility: remove 'div' container for dropdown button #9753

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

browser: accessibility: remove 'div' container for dropdown button #9753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
4033845
browser: accessibility: remove 'div' container for dropdown button
hcvcastro Aug 8, 2024
e59884b
browser: accessibility: remove more 'div' dropdown button
hcvcastro Aug 8, 2024
0aa95ae
browser: accessibility: fixup color dropdown button container
hcvcastro Aug 8, 2024
39c4a01
browser: accessibility: set up all dropdown buttons to display 'flex'
hcvcastro Aug 9, 2024
93f23db
browser: accessibility: button group image and label
hcvcastro Aug 9, 2024
eac8b86
browser: accessibility: fix notebookbar button display
hcvcastro Aug 9, 2024
0b07ece
browser: accessibility: fix inline label button
hcvcastro Aug 12, 2024
5e23e34
browser: accessibility: fix inline label button with no command
hcvcastro Aug 12, 2024
3228827
browser: accessibility: remove button parent container
hcvcastro Aug 12, 2024
cc18a07
browser: accessibility: fix arrow click button
hcvcastro Aug 13, 2024
71a5f22
cypress: fix prettier builddir != srcdir
Aug 21, 2024
a85b402
cypress: remove '.arrowbackground' class selector
Aug 21, 2024
1f03737
cypress: remove '-button' suffix
Aug 21, 2024
6b30ef5
cypress: remove 'button' class selector
Aug 21, 2024
a3896bb
cypress: fix 'button' class selector
Aug 21, 2024
fdf319c
cypress: add listener protocol function
hcvcastro Aug 19, 2024
6cceada
cypress: fix 'clickOnFirstCell' function
hcvcastro Aug 16, 2024
e1a1b1a
cypress: fix "selectEntireSheet" function
Aug 20, 2024
b3178ef
cypress: fix "selectTextShape" function
Aug 20, 2024
c09931a
cypress: fix "selectFullTable" function
Aug 21, 2024
daf7015
cypress: fix impress table selections
Aug 21, 2024
d9bf4b5
cypress: fix "selectOptionNotebookbar" function
hcvcastro Aug 21, 2024
bfec81c
browser: accessibility: replace jquery 'addClass' function
hcvcastro Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions browser/css/cool.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
--btn-size-s: 20px;
--btn-img-size-s: calc(var(--btn-size-s) - var(--btn-padding) * 2);

--btn-dropdown-size: 8px;
--border-radius: 4px; /* buttons, widgets */
--border-radius-large: 10px; /* dialog */

Expand Down
37 changes: 37 additions & 0 deletions browser/css/jsdialogs.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1784,6 +1784,20 @@ input[type='number']:hover::-webkit-outer-spin-button {
align-items: center;
}

.jsdialog:not(.menubutton)..jsdialog:not(.dropdown) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo ..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

width: var(--btn-size);
}

.jsdialog .ui-content.unobutton.no-label.dropdown {
width: calc(var(--btn-size) + var(--btn-dropdown-size))
}

.jsdialog .ui-content.unobutton:not(.dropdown) {
height: var(--btn-size);
min-width: var(--btn-size);
padding: 0px;
}

.has-dropdown > .ui-content.unobutton {
width: auto;
}
Expand All @@ -1804,13 +1818,36 @@ input[type='number']:hover::-webkit-outer-spin-button {
background-color: var(--color-background-darker);
}

.dropdown {
display: flex;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

below has-dropdown class is now unused? was replaced by dropdown

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I forgot to remove it.

.unotoolbutton.has-dropdown {
display: grid;
align-items: center;
grid-auto-flow: column;
grid-template-rows: auto 0px;
}

.unobutton.dropdown::after {
content: '';
height: 0px;
border: 4px solid transparent;
border-top: 5px solid var(--color-main-text);
display: inline-block;
margin: auto;
}

.container-button,
.container-color-inline {
display: inline-block;
pointer-events: none;
}

.unotoolbutton.jsdialog.sidebar.ui-content > .arrowbackground {
width: auto;
}

/* handling show/hide state */
.hidden {
display: none !important;
Expand Down
3 changes: 1 addition & 2 deletions browser/css/jssidebar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,7 @@ div.sidebar.ui-grid .checkbutton.sidebar,

.sidebar.ui-pushbutton,
.sidebar.spinfield,
.sidebar.ui-listbox,
.sidebar.menubutton:not(.has-dropdown) {
.sidebar.ui-listbox {
width: 121px;
}

Expand Down
6 changes: 3 additions & 3 deletions browser/css/mobilewizard.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,8 +672,8 @@ a.leaflet-control-zoom-in {
background-color: var(--color-background);
}
.unotoolbutton.mobile-wizard {
padding: 4% !important;
margin: 0px !important;
padding: 0px !important;
margin: 8px !important;
float: left;
}
#selectcolor.mobile-wizard.toolbox.level-1 {
Expand Down Expand Up @@ -943,7 +943,7 @@ input[type='checkbox']#UseBandingColumnStyle, input[type='checkbox']#UseLastColu
#mobile-wizard #FontworkSameLetterHeights > img {
filter: brightness(3);
}
#mobile-wizard .unotoolbutton.no-label button {
#mobile-wizard .unotoolbutton.no-label {
background-color: transparent;
border: 1px solid transparent;
}
Expand Down
17 changes: 10 additions & 7 deletions browser/css/notebookbar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,8 @@ html[data-theme='dark'] .savemodified.unotoolbutton .unobutton img {
padding: 0px !important;
}

.unotoolbutton.notebookbar .unobutton {
.unotoolbutton.notebookbar.unobutton {
cursor: pointer;
box-sizing: border-box;
padding: var(--btn-padding);
width: var(--btn-size);
Expand Down Expand Up @@ -240,6 +241,12 @@ html[data-theme='dark'] .savemodified.unotoolbutton .unobutton img {
background-color: var(--color-background-darker);
}

.unotoolbutton.notebookbar .unobutton.dropdown {
display: flex;
width: 100%;
alig-items: center;
}

.jsdialog .ui-tabs-content {
margin-top: 10px;
}
Expand All @@ -260,6 +267,8 @@ html[data-theme='dark'] .savemodified.unotoolbutton .unobutton img {
padding: 0px 5px !important;
line-height: normal;
grid-column: 2;
margin: auto;
vertical-align: bottom;
}

#table-HomeTab .unospan-uptoolbar:not(.disabled) {
Expand Down Expand Up @@ -319,12 +328,6 @@ html[data-theme='dark'] .savemodified.unotoolbutton .unobutton img {
text-align: center;
}

.unotoolbutton.notebookbar.has-label > *:not(.arrowbackground) { /*so they stay side by side*/
display: table-cell;
width: 100%;
height: 100%;
}

.unotoolbutton.notebookbar.has-label {
text-align: center;
}
Expand Down
Loading
Loading