browser: accessibility: remove 'div' container for dropdown button #9753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcvcastro
force-pushed
the
pr/master/78
branch
4 times, most recently
from
bc6ba53 to
fff2ed4
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hcvcastro
force-pushed
the
pr/master/78
branch
19 times, most recently
from
a7c9948 to
dc9c65e
Compare
hcvcastro
force-pushed
the
pr/master/78
branch
6 times, most recently
from
80d37a1 to
e27fdeb
Compare
hcvcastro
force-pushed
the
pr/master/78
branch
from
63a3b27 to
2c77477
Compare
|
The Dark mode looks fine according to my test. Try again with the clean ups added |
eszkadev
requested changes
Aug 29, 2024
| } else { | ||
| JSDialog.AddOnClick(control.button, clickFunction); | ||
| } | ||
| JSDialog.AddOnClick(control.button, clickFunction); |
There was a problem hiding this comment.
Split Button is one of the widgets in the weld:: library in LO - we have to support it!
It can appear in any dialog we get from core. Also color picker buttons have to be split buttons.
We had requirements wrt that, also it's standard in all the text editors.
There was a problem hiding this comment.
Please comment and clarify in the task description, I am just doing the task description requirements!.
There was a problem hiding this comment.
I mean you removed the feature by this change, please do not remove existing functionality.
Color picker button had 2 parts: (apply last color) (open dropdown menu), after your change there is only single function: (open dropdown menu). I wrote it in the previous revision of the PR already.
Requirement is just to not create regressions in this case.
Would be good to create cypress test for it (as it seems to be missing)
|
@hcvcastro ping: This has to be rebased |
Change-Id: Ic0f414cacab0c48e919157ddd3ad79962767b6c5 Signed-off-by: Henry Castro <[email protected]>
Change-Id: If87fad3dfd2fb3727de3a0ed00a4b56ac115d10f Signed-off-by: Henry Castro <[email protected]>
Change-Id: I93d67c3815e8004f90d59ba3d1db139e5b8ba422 Signed-off-by: Henry Castro <[email protected]>
Change-Id: Ie2d2703c36d05d972e40a07b016f2c7d8cb92782 Signed-off-by: Henry Castro <[email protected]>
Change-Id: I10e8b0678e44a9c9da63744fc597c033b1dd68f5 Signed-off-by: Henry Castro <[email protected]>
Change-Id: I274e7fc4184ceb5c0d7fc526bfacc661df62b726 Signed-off-by: Henry Castro <[email protected]>
Change-Id: Id8968e45d1b7133bc6eb0559f242a14695c2d725 Signed-off-by: Henry Castro <[email protected]>
Change-Id: I0b2c09eaca08f2656b79e6f03337be0ff0e15c78 Signed-off-by: Henry Castro <[email protected]>
Change-Id: I8acb0dcabf81dd8dc0d01627e0e0dd2386171b4d Signed-off-by: Henry Castro <[email protected]>
Change-Id: I25551dc457f6f3dc1380b8ec25d0180889894cd2 Signed-off-by: Henry Castro <[email protected]>
Change-Id: I2388c8441d8e2b880a862e44d9ab8a0fbe815adb Signed-off-by: Henry Castro <[email protected]>
Change-Id: If4c61034ca17b4de0c48ebe12f44e962132b07a7 Signed-off-by: Henry Castro <[email protected]>
Change-Id: I1e17808b9427ecda3f6a451e6ede521e0550c622 Signed-off-by: Henry Castro <[email protected]>
Change-Id: I6c7f99f440834fecba552f7b9ac27d256852fe95 Signed-off-by: Henry Castro <[email protected]>
Change-Id: Ie5293abee386c52fac0aa4fd8169fd6e0bba122b Signed-off-by: Henry Castro <[email protected]>
Change-Id: I61aa46abdc697b8e8fc5b6525378e428a954838b Signed-off-by: Henry Castro <[email protected]>
It depends on server response, not the element value. Change-Id: I97d06655a758b189c6a35297938d481fe4b86df1 Signed-off-by: Henry Castro <[email protected]>
It depends on server response. Change-Id: Ia45719a11624eb995bd6bc7cba20dfc6986f88b0 Signed-off-by: Henry Castro <[email protected]>
All the handles are visible because the side bar is not visible. Change-Id: Ie4a83954e2df8ce54aa518eaf797536f570079da Signed-off-by: Henry Castro <[email protected]>
It depends on the visible area. Change-Id: Ia68562f50fe70b6b91c474c30dd2f1b757dcbd1b Signed-off-by: Henry Castro <[email protected]>
It depends on server response. Change-Id: I272f6acd0f5efba0230baceb4d88c1febf57b745 Signed-off-by: Henry Castro <[email protected]>
It no longer has a parent div container. Change-Id: Ie34e7227544a7f4abacc185caa1a2a3aa8e7a391 Signed-off-by: Henry Castro <[email protected]>
Change-Id: Id9bc9e24a2152705696b4dd77d50d72c6a74ada7 Signed-off-by: Henry Castro <[email protected]>
hcvcastro
force-pushed
the
pr/master/78
branch
from
2c77477 to
bfec81c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ic0f414cacab0c48e919157ddd3ad79962767b6c5
Signed-off-by: Henry Castro [email protected]