Formula wizard - collapsed mode fix #13276
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eszkadev
commented
Oct 24, 2025
eszkadev
commented
- followup for Formula wizard collapsing fix #13235
- cypress test
eszkadev
force-pushed
the
private/eszkadev/formula-wizard
branch
2 times, most recently
from
7fa5422 to
b632aa5
Compare
Contributor
Author
|
it requires to remove referencing by ids in the cypress tests (use class which has the same value always instead) |
eszkadev
force-pushed
the
private/eszkadev/formula-wizard
branch
from
b632aa5 to
904b612
Compare
Merged
eszkadev
force-pushed
the
private/eszkadev/formula-wizard
branch
from
904b612 to
745fa58
Compare
eszkadev
force-pushed
the
private/eszkadev/formula-wizard
branch
from
745fa58 to
65e6ddb
Compare
Contributor
Author
|
another round of cypress patches for this PR: #13460 |
Contributor
Author
|
next part of the required cypress rework: #13471 |
eszkadev
force-pushed
the
private/eszkadev/formula-wizard
branch
2 times, most recently
from
1e81e8f to
daea901
Compare
Contributor
Author
|
impress table tests fix: #13478 |
Contributor
Author
|
writer color picker fix: #13481 |
eszkadev
force-pushed
the
private/eszkadev/formula-wizard
branch
from
daea901 to
accac9d
Compare
Contributor
Author
|
writer line spacing item: #13489 |
eszkadev
force-pushed
the
private/eszkadev/formula-wizard
branch
from
accac9d to
eea580c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Author
|
calc top toolbar fixes: #13512 |
eszkadev
force-pushed
the
private/eszkadev/formula-wizard
branch
from
eea580c to
dc60a92
Compare
Fixes #13097 which wasn't fully solved in previous patch ea66f06 Signed-off-by: Szymon Kłos <[email protected]> Change-Id: I0591988c784158857771783c5a2003acdc3c98f6
Signed-off-by: Szymon Kłos <[email protected]> Change-Id: I0f0b837ca1905b2deb4e8567484dd1833cfe6965
- it can happen that last generated id is not yet inserted into DOM - use util's counter to avoid that problem - increment even if not found - it's important for not attached DOM nodes -> consequence of layouting tasks with delayed DOM touching Signed-off-by: Szymon Kłos <[email protected]> Change-Id: Ib89946a14a289e297e1d64e02a16a6020b737941
- MakeIdUnique injects random numbers as it was fixed - we need in the future some register for our dropdowns to avoid query Signed-off-by: Szymon Kłos <[email protected]> Change-Id: I7fe1030b2b33c1099cabaa3e954799c1f61268d7
- MakeIdUnique makes id changed by adding suffix - Then we had problem to find the element as we used DOM id - This patch saves original id as additional attribute - When lookup is done we use it first Signed-off-by: Szymon Kłos <[email protected]> Change-Id: Ia97973a8713bff87329fb74e5e4b870b4675a16b
Signed-off-by: Szymon Kłos <[email protected]> Change-Id: I1ef1968471bf73942682182165c1431ecd08a31c
eszkadev
force-pushed
the
private/eszkadev/formula-wizard
branch
from
dc60a92 to
e11368c
Compare
Contributor
Author
|
another PR with impress fixes: #13539 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.