jsdialog: identify dropdowns with unique id

- MakeIdUnique injects random numbers as it was fixed
- we need in the future some register for our dropdowns to
  avoid query

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: I7fe1030b2b33c1099cabaa3e954799c1f61268d7

Author: eszkadev

browser/src/control/jsdialog/Util.Dropdown.js

@@ -205,5 +205,7 @@ JSDialog.CloseAllDropdowns = function () {
 };
 
 JSDialog.GetDropdown = function (id) {
-	return document.body.querySelector('#' + _createDropdownId(id));
+	// remember it can get some random numbers due to JSDialog.MakeIdUnique
+	// TODO: use some register for it
+	return document.body.querySelector('[id^="' + id + '"].modalpopup');
 };

cypress_test/integration_tests/desktop/calc/delete_objects_spec.js

@@ -22,9 +22,9 @@ describe(['tagdesktop', 'tagnextcloud', 'tagproxy'], 'Delete Objects', function(
 	});
 
 	it('Delete Shapes', function() {
-		cy.cGet('#toolbar-up #overflow-button-other-toptoolbar .arrowbackground').click();
+		cy.cGet('#toolbar-up #other-toptoolbar .unoDefaultNumbering .arrowbackground').click();
 
-		cy.cGet('#insertshapes').click();
+		cy.cGet('#other-toptoolbar .unoBasicShapes').click();
 		cy.cGet('.col.w2ui-icon.symbolshapes').should($el => { expect(Cypress.dom.isDetached($el)).to.eq(false); }).click();
 
 		cy.cGet('#test-div-shapeHandlesSection')
@@ -38,9 +38,10 @@ describe(['tagdesktop', 'tagnextcloud', 'tagproxy'], 'Delete Objects', function(
 	});
 
 	it('Delete Chart' , function() {
-		cy.cGet('#toolbar-up #overflow-button-other-toptoolbar .arrowbackground').click();
+		cy.cGet('#toolbar-up #other-toptoolbar .unoDefaultNumbering .arrowbackground').click();
+
 		//insert
-		cy.cGet('#insertobjectchart').click();
+		cy.cGet('#other-toptoolbar .unoInsertObjectChart').click();
 		cy.cGet('.jsdialog-overlay').click();
 		cy.cGet('.ui-pushbutton.jsdialog.button-primary').should($el => { expect(Cypress.dom.isDetached($el)).to.eq(false); }).click();
 		cy.cGet('#test-div-shapeHandlesSection').should('exist');