Skip to content

[Sky Island] Require the player to examine the statue to receive warp shards#86282

Merged
Maleclypse merged 1 commit intoCleverRaven:masterfrom
thaelina:warp-shards-require-effort
Apr 6, 2026
Merged

[Sky Island] Require the player to examine the statue to receive warp shards#86282
Maleclypse merged 1 commit intoCleverRaven:masterfrom
thaelina:warp-shards-require-effort

Conversation

@thaelina
Copy link
Copy Markdown
Contributor

@thaelina thaelina commented Apr 6, 2026

Summary

Mods "[Sky Island] Require the player to examine the statue to receive warp shards"

Purpose of change

Previously, warp shards were lying on the ground for the Find Warp Shards mission. This required the player to walk over to them and pick them up. When implementing challenge mode, I changed the mission to complete when the player got close enough since the previous method wasn't able to be adjusted on the fly for Challenge mode.
Since these missions can spawn inside of houses that have zeds, this reintroduces the danger associated with those locations.

Describe the solution

Change the MISSION_BONUS_TREASURE end effect to just a simple message telling the player they have to find a way to get the shards from the statue. This should naturally lead them to examine the statue. The statue description clearly states there are warp shards in the palm of its hand.
Using the examine actions on the f_warpshardrewardstatue warp shard statue will fire an EOC that performed the same actions as the mission completion used to and execute a ter_furn_transform to change the statue into a new one with a description change to indicate it no longer has the shards.

Describe alternatives you've considered

Testing

Game loads, mission is generated as normal, statue grants shards and transforms as expected.

Additional context

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @gettingusedto

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Missions Quests and missions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Mods: Sky Island Anything about the Sky Island mod astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • "You retreieved the warp shards from the statue."

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@thaelina thaelina force-pushed the warp-shards-require-effort branch from 2c41e6f to 97bccd7 Compare April 6, 2026 01:04
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 6, 2026
@Maleclypse Maleclypse merged commit 594376b into CleverRaven:master Apr 6, 2026
29 of 32 checks passed
@thaelina thaelina deleted the warp-shards-require-effort branch April 6, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Missions Quests and missions Mods: Sky Island Anything about the Sky Island mod Mods Issues related to mods or modding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants