Remember crafting details panel state between sessions#86276
Open
evilbananas wants to merge 2 commits intoCleverRaven:masterfrom
Open
Remember crafting details panel state between sessions#86276evilbananas wants to merge 2 commits intoCleverRaven:masterfrom
evilbananas wants to merge 2 commits intoCleverRaven:masterfrom
Conversation
github-actions
bot
added
Info / User Interface
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
astyled
Contributor
|
sorry for not seeing this go up earlier. from a quick review, looks like that was as simple as i hoped. i'll get to testing it shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Interface "The new ImGui crafting UI will remember if recipe details are expanded/collapsed across play sessions"
Purpose of change
This is a compromise for the proposal in #86268. It allows the state of the details section of the crafting UI to be maintained across play sessions, similar to the crafting favorites, hidden recipes, etc.
Describe the solution
The state of the crafting details for a recipe being collapsed/expanded is stored in a similar way to other persistent data in the crafting UI.
Describe alternatives you've considered
Make the details expanded by default - debatable and my personal preference but default is still collapsed.
Testing
Compiled on Windows. Created a character, opened the crafting UI and expanded the recipe details. Saved and closed the game. Loaded game again and verified crafting details were still expanded.
Additional context