Fix drystone and brick roof terrain#86274
Open
ParselyBunny wants to merge 3 commits intoCleverRaven:masterfrom
Open
Fix drystone and brick roof terrain#86274ParselyBunny wants to merge 3 commits intoCleverRaven:masterfrom
ParselyBunny wants to merge 3 commits intoCleverRaven:masterfrom
Conversation
github-actions
bot
added
[JSON]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Man-made drystone and brick walls currently have a natural rock roof by default. It's more appropriate for these artificial walls to have matching roofs.
Closes #73316.
Describe the solution
Man-made drystone and brick walls copy from abstract wall definitions and thus inherit a natural rock roof. I've fixed this by overriding the drystone and brick wall roofs with a more specific value. I defined a new drystone roof for this purpose, since one didn't already exist. The brick roof already exists, so I updated the brick wall definition to use a more appropriate roof.
Describe alternatives you've considered
I considered changing the description of the rock roof to remove the word "natural" and make it more generic, but it's pretty consistently used in other terrain definitions (such as in underground mud, dirt, and sand floors) as natural rock.
Testing
The changes are trivial and don't require playtesting.
Additional context
While the original issue (#73316) seems to use the term "rock" to describe things like naturally formed minerals and "stone" to describe man-made constructions using rock materials, the terms "rock" and "stone" are used interchangeably throughout the data.