simplify vpart_info::has_control_req

[sonphantrung]

Summary

None

Purpose of change

I feel the check can be simplified a bit.

Describe the solution

As the title suggests.

Describe alternatives you've considered

• Just dump the whole function entirely, but it'll be too long to read
• I'm thinking of adding terrain type of argument that will remove the need for duplicate can_control_* functions. It's beyond my expertise — sadly.

Testing

Should work

Additional context

This is a result of me obsessively reading the same PR again and again just to have more understanding of the code.

[ehughsbaird]

I don't think this is an improvement.
You're making a function that tells us if a vehicle part has a control requirement require passing in data from that vehicle part, and it will work incorrectly if you pass in data from another vehicle part.

You could have a has_control_req_air and has_control_req_land functions if you think it's important to split these, but this just seems like churn.