Minor parse_tags fix + doc update, mapgen parameter doc update #81810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snippetises <punc> and deduplicates time_durations to_string()
No clue why I didn't do this originally, it works fine
github-actions
bot
added
<Documentation>
RenechCDDA
reviewed
Jul 15, 2025
| `<spell_description:ID>` | The description of the trait from ID | ||
| Certain entries like the snippets above are taken from the game state as opposed to JSON; they are found in the npctalk function parse_tags. In dialogue the alpha talker is the avatar and the beta talker is the NPC. | ||
|
|
||
| | Field | Uses alpha | Uses beta | Description |
There was a problem hiding this comment.
This is a really obnoxious table to read. The "uses alpha"/"uses beta" columsn should just be one column which lists either "Alpha" or "Beta" or "N/A". Since checking alpha or beta is mutually exclusive, there is no need for two columns.
(The entry for context_val appears to be just plain wrong, since it is a context val.)
github-actions
bot
added
json-styled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Forgot to document keybind tags when I moved them to parse_tags
Forgot to document omt_stack scope for parameters when I added that
Describe the solution
Rewrite mapgen parameter docs bc I didn't think the ordering was ideal and they didn't feel very approachable
Update parse_tags docs from the code
Made a snippet along its already snippetised brethren bc it doesn't need to be a tag and parse_tags already expands snippets so there's no coverage issue
Remove the legacy keybind tag handling that I'm not sure why I left
Describe alternatives you've considered
Not overly happy with the unbound message bc there's no sensible way to contextualise the category id that I'm aware of but it at least provides the translated name to search for if you can find the right menu.
Adding a usage of parameters picking palettes, the syntax is identical though it'd just be to drive home that you can use these in most fields
Testing
Tested the new keybind tag error messages fire correctly
Checked tutorial snippets going via parse_tags doesn't magically blow up anything
Additional context